818960 - BaselineCompiler: Add baseline-specific spew

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Debugging baseline spew is difficult right now since the only spew flags are those reused from Ion.  Add a new set of baseline spew flags and change baseline compiler to use them.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Add baseline-specific spew channels.

Adds following channels:

BaselineAbort - for compile-time aborts in baseline
BaselineCompile - for compile-time messages
BaselineOp - for compile-time verbose op-specific messages
BaselineIC - for compile-time IC-related messages.
BaselineICFallback - for runtime IC "slowpath" messages

Channels enable by IONSPEW=
bl-abort
bl-compile
bl-op
bl-ic
bl-ic-fb

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 689262 [details] [diff] [review]
Add baseline-specific spew channels.

Review of attachment 689262 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineCompiler.cpp
@@ +42,5 @@
>  
>  MethodStatus
>  BaselineCompiler::compile()
>  {
> +    IonSpew(IonSpew_BaselineCompile, "Baseline compiling script %s:%d (%p)",

I use IONFLAGS=scripts,aborts a lot, so printing scripts to a separate channel would be nice.

Comment 3

[Kannan Vijayan [:djvj]]

Changed IonSpew_BaselineCompile back to IonSpew_BaselineScripts, as per review.
Also changed "bl-abort" to "bl-aborts" to mimic Ion's convention.

Pushed: https://hg.mozilla.org/projects/ionmonkey/rev/d9327faa1694