Closed
Bug 819118
Opened 12 years ago
Closed 12 years ago
GC: Use accessor for script access in Ion's TI oracle
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: terrence, Unassigned)
References
Details
Attachments
(1 file)
70.55 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
When we convert the TypeInferenceOracle accessors over to taking UnrootedScript, we will not be able to pass HeapPtrScript to these. Barrier.h imports Root.h so we can't just add an a constructor trivially. We could use an inlines file to Root.h to handle the inclusion ordering, but the better solution is to just go through an accessor. The conversion is trivial except for the 8 call sites that need to take a HandleScript and the one spot where |script| was referring to the call target instead of |this->script_|. I simply renamed this usage in this case to make it clearer what "script" is what.
Attachment #689404 -
Flags: review?(wmccloskey)
Attachment #689404 -
Flags: review?(wmccloskey) → review+
Reporter | ||
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4356739a6f44
Reporter | ||
Comment 2•12 years ago
|
||
And backed out in: https://hg.mozilla.org/integration/mozilla-inbound/rev/2324b9d9f17f A jit-test or jstest really should have tripped this failure. Will investigate more on Monday.
Reporter | ||
Comment 3•12 years ago
|
||
Green Try run + fixed try run at: https://tbpl.mozilla.org/?tree=Try&rev=25e33174ebfc https://tbpl.mozilla.org/?tree=Try&rev=9167c246e1c1 Pushed at: https://hg.mozilla.org/integration/mozilla-inbound/rev/9602f98a6a70
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9602f98a6a70
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•