819164 - Can't connect to network with SSID that includes UTF-8 encoded characters

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Brendan Eich [:brendan]]

Here at the Hotel St. Regis, cbeard tried making a hotspot with his iPhone, which requires a password. In that case the B2G phone couldn't connect, I think. Chris should say more.

/be

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I'm not sure if anyone around has an iPhone that we can test on easily. I'll ask around.

Comment 2

[Doug Turner (:dougt)]

Blake, does the wpa supplicant support ad hoc?

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: JavaScript error when trying to connect to iPhone hotspot

We can't handle the ssid with special characters, for instance "Tim’s iPhone 4S". We got the javascript error when ssid has character `'`.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Embarrassing!

Comment 5

[Vincent Chang[:vchang][changyihsin]]

More information, look like ssid is encoded in utf8. So `'` is represented in 0xe2 0x80 0x99.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

The problem is that readString interprets the string as UTF-8, so reply_len was not a valid index into str. The fix is to fix up the string (do nul termination and newline-nuking) before we try to convert to utf-8. One nice thing about writing this in JS using ctypes: this was a misbehavior bug dealing with indices into arrays that's not a security vulnerability!

Thanks a ton for the debugging help, Vincent.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

One problem I'm having right now is that the settings app is broken too badly to connect to any network (being tracked by bug 818056) so I can't verify that my patch fixes this (other than in my test, I stopped seeing us throw exceptions).

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1afcff95d353

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1afcff95d353

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f21e3aaa9142
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bb7d01c8e9d2