Closed
Bug 821158
Opened 13 years ago
Closed 13 years ago
Fix the patch for bug 819164
Categories
(Firefox OS Graveyard :: Wifi, defect)
Firefox OS Graveyard
Wifi
Tracking
(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 819164 introduced a massive bug because I thought that ctypes.size_t().value was an integer. It is an object instead.
|
Assignee | |
Comment 1•13 years ago
|
||
It's all in the comment in the patch.
Attachment #691669 -
Flags: review?(jst)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 691669 [details] [diff] [review]
Fix
r=jst!
Attachment #691669 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Updated•13 years ago
|
Target Milestone: --- → B2G C3 (12dec-1jan)
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 5•13 years ago
|
||
|
|
Assignee | |
Comment 7•13 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6)
> Should this have a test, BTW?
We currently don't have any way to write unit tests for this code :/
You need to log in
before you can comment on or make changes to this bug.
Description
•