Closed Bug 821158 Opened 12 years ago Closed 12 years ago

Fix the patch for bug 819164

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Status:
RESOLVED FIXED
Milestone:
B2G C3 (12dec-1jan)
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file)

Fix
1.49 KB, patch
jst
: review+
Details | Diff | Splinter Review 
The patch in bug 819164 introduced a massive bug because I thought that ctypes.size_t().value was an integer. It is an object instead.
Attached patch Fix — — Splinter Review 
It's all in the comment in the patch.
Attachment #691669 - Flags: review?(jst)
Comment on attachment 691669 [details] [diff] [review]
Fix

r=jst!
Attachment #691669 - Flags: review?(jst) → review+
Target Milestone: --- → B2G C3 (12dec-1jan)
https://hg.mozilla.org/mozilla-central/rev/72913ea85419
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Should this have a test, BTW?
Flags: in-testsuite?
(In reply to Ryan VanderMeulen from comment #6)
> Should this have a test, BTW?

We currently don't have any way to write unit tests for this code :/
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: