Figure out if getPayload should call getCounters

RESOLVED INVALID

Status

()

Toolkit
Telemetry
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: espindola, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

From bug 818549:

It also looks like we might have a bug in the getPayload() method.. it never calls getCounters() !
It is not clear we should call it. It is used to set this._startupIO.startupSessionRestoreReadBytes and this._startupIO.startupSessionRestoreWriteBytes in the sessionstore-windows-restored message.

Simply calling gatherStartup instead of gatherStartupInformation in getPayload will produce a more current (inaccurate) value for those member variables no?

Or is your intention to call  getCounters() and store it in new member variables (say ReadsSoFar and WritesSoFar)?
(In reply to Rafael Ávila de Espíndola (:espindola) from comment #1)
> It is not clear we should call it. It is used to set
> this._startupIO.startupSessionRestoreReadBytes and
> this._startupIO.startupSessionRestoreWriteBytes in the
> sessionstore-windows-restored message.
> 
> Simply calling gatherStartup instead of gatherStartupInformation in
> getPayload will produce a more current (inaccurate) value for those member
> variables no?

Right
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.