819341 - Add a space before "Get Help" button in Feedback page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Cristian Boldan]

Steps to reproduce:
1. Load MP Feedback page https://marketplace-dev.allizom.org/settings/feedback
2. Observe the "Get Help" button under the Feedback form

Expected resutls:
There is a space between Feedback form and "Get Help" button.

Actual results:
"Get Help" button is right under the feedback form, not consistent with mobile view.

Notes/Issues:
Verified on FF20 (Win 7)
Screencast for this issue http://screencast.com/t/3emTyZeN

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/d52b74a

Comment 2

[Maureen Hanratty]

Attachment: Feedback page missing title

The "Feedback" screen is also missing a title.

Comment 3

[Maureen Hanratty]

Attachment: Feedback as overlay

This is the final design for Feedback in an overlay--it was with the over desktop mocks but I don't think there was a bug filed for it. Let me know if I should file a bug for the new design.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maureen Hanratty from comment #2)
> Created attachment 689822 [details]
> Feedback page missing title
> 
> The "Feedback" screen is also missing a title.

It's not anymore: https://marketplace-dev.allizom.org/settings/feedback

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maureen Hanratty from comment #3)
> Created attachment 689824 [details]
> Feedback as overlay
> 
> This is the final design for Feedback in an overlay--it was with the over
> desktop mocks but I don't think there was a bug filed for it. Let me know if
> I should file a bug for the new design.

Could you file a new bug for that? I can take it. Thanks!

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #5)
> (In reply to Maureen Hanratty from comment #3)
> > Created attachment 689824 [details]
> > Feedback as overlay
> > 
> > This is the final design for Feedback in an overlay--it was with the over
> > desktop mocks but I don't think there was a bug filed for it. Let me know if
> > I should file a bug for the new design.
> 
> Could you file a new bug for that? I can take it. Thanks!

Actually, don't. That's bug 811354.

Comment 7

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/settings/feedback on FF20 (Win 7)
Attaching postfix screenshot.
Closing bug.

Comment 8

[Cristian Boldan]

Attachment: postfix get help