Closed Bug 819613 Opened 8 years ago Closed 7 years ago

Firefox for Metro should support mouse gestures/buttons for back/forward

Categories

(Core Graveyard :: Widget: WinRT, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: KWierso, Assigned: jimm)

References

()

Details

(Keywords: platform-parity, Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff30)

Attachments

(2 files)

I have the Microsoft Touch mouse, which includes a touch gesture for going back/forward in a browser's history (or in other programs where it makes sense) by swiping my thumb either down or up against the side of the mouse. This works in desktop Firefox and IE, as well as Metro IE. 

It doesn't seem to do anything in Metro Firefox. I think it should, at least for parity with IE.

The MozillaZine thread linked in this bug's URL field says that the hardware back/forward buttons on Logitech mice also don't work in Metro Firefox, while it does work everywhere else. I'd guess it's the same issue for both the gestures and the buttons?
Blocks: 785473
Keywords: pp, ux-efficiency
Whiteboard: [metro-mvp?][LOE:1]
not blocking but wanted as soon as we have the time.
Whiteboard: [metro-mvp?][LOE:1] → [metro-mvp][LOE:1]
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp-][LOE:1]
OS: Windows 8 → Windows 8 Metro
No longer blocks: 785473
Keywords: pp, ux-efficiency
Whiteboard: [metro-mvp-][LOE:1]
No longer blocks: metrov2planning
Whiteboard: [feature]
Whiteboard: [feature] → [feature] p=0
Depends on: 967819
Removing 'ux' keyword as UX dependency bug has been created which blocks bug 819613.
Keywords: ux-efficiency
We need to add support for application command messages - 

http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#5091
http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#3698
Component: Input → Widget: WinRT
Product: Firefox for Metro → Core
Version: unspecified → Trunk
OS: Windows 8 Metro → Windows 8.1
Attached patch widget patch v.1Splinter Review
I have to find a keyboard i can test this with.
Assignee: nobody → jmathies
This is working in widget, but we also need front end support - 

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1471
Hey Jim, can you provide a point value.
Status: NEW → ASSIGNED
Flags: needinfo?(jmathies)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [feature] p=0 → [feature] p=0 s=it-30c-29a-28b.1
Target Milestone: --- → mozilla30
No longer depends on: 967819
Attachment #8370395 - Flags: review?(sfoster)
Flags: needinfo?(jmathies)
Attachment #8370375 - Attachment description: patch v.1 → widget patch v.1
Attachment #8370375 - Flags: review?(tabraldes)
Whiteboard: [feature] p=0 s=it-30c-29a-28b.1 → [feature] p=0 s=it-30c-29a-28b.1 p=1
Whiteboard: [feature] p=0 s=it-30c-29a-28b.1 p=1 → [feature] s=it-30c-29a-28b.1 p=1
Comment on attachment 8370395 [details] [diff] [review]
browser patch v.1

Review of attachment 8370395 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure how to test? Code-wise looks fine though

::: browser/metro/base/content/browser-ui.js
@@ +1145,5 @@
>      }
>    },
>  
> +  handleAppCommandEvent: function (aEvent) {
> +    switch (aEvent.command) {

Nit: I would normally indent the switch block?
Attachment #8370395 - Flags: review?(sfoster) → review+
(In reply to Sam Foster [:sfoster] from comment #8)
> Comment on attachment 8370395 [details] [diff] [review]
> browser patch v.1
> 
> Review of attachment 8370395 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not sure how to test? Code-wise looks fine though
> 
> ::: browser/metro/base/content/browser-ui.js
> @@ +1145,5 @@
> >      }
> >    },
> >  
> > +  handleAppCommandEvent: function (aEvent) {
> > +    switch (aEvent.command) {
> 
> Nit: I would normally indent the switch block?

I was not able to test much either aside from Back/Forward. The widget code comes from win32 widget though which we now share, and the front end code is pulled from desktop's browser.js, so we should be ok.
Comment on attachment 8370375 [details] [diff] [review]
widget patch v.1

Review of attachment 8370375 [details] [diff] [review]:
-----------------------------------------------------------------

Seems pretty straightforward and it sounds like you tested with the 'back' and 'forward' keys
Attachment #8370375 - Flags: review?(tabraldes) → review+
Odd, never run into this before, B2G Desktop Windows Opt failed to link due to missing nsGkAtoms in nsWindowBase. Windows builds were fine.
(In reply to Jim Mathies [:jimm] from comment #13)
> Odd, never run into this before, B2G Desktop Windows Opt failed to link due
> to missing nsGkAtoms in nsWindowBase. Windows builds were fine.

B2G Desktop Windows Op isn't a unified build.
Whiteboard: [feature] s=it-30c-29a-28b.1 p=1 → p=1 s=it-30c-29a-28b.1 r=ff30
For testing and verification.  Reopen if any defects found.
Flags: needinfo?(kamiljoz)
Setting needinfo on myself to try to verify this once I track down the dongle for my mouse.
Flags: needinfo?(kwierso)
We've also ordered the mouse to the TO office so will have it for any future test cases. If it comes in before Wes can find his dongle, I'll complete verification.
Yeah, I've looked in all of the places where the dongle could possibly be and I don't see it. Guess this is up to the TO office to verify, now. :(
Flags: needinfo?(kwierso)
no worries Wes, I ordered a mouse and it shipped today.. Hopefully it arrives tomorrow or by Monday - Tuesday. Thanks for checking!
Clearing the "needinfo" as the metrofx project has been cancelled. Unfortunately the mouse came in after the project was cancelled :(
Flags: needinfo?(kamiljoz)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.