819786 - PLMN entries reading reports invalid entry when not invalid

Status: RESOLVED DUPLICATE of bug 819790

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN entries length = 2
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [0]: '2,248,16'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN entry 0 is invalid.

This is due to the GSM PDU Helper reading hex octets (GsmPDUHelper.readHexOctet()) and the values not being handled. This is not a problem in our case and we can gracefully continue. If we don't, we do not read the PLMN entries.

Comment 1

[:gerard-majax]

Attachment: Continuing after the exception

The exception that is triggered is expected and we can safely continue.

Comment 2

[:gerard-majax]

While the i -> idx change in the loop is correct, the try/catch/finally turns out to be useless. Always good things to re-read patch after sleeping :)

Comment 3

[:gerard-majax]

Attachment: Removing the try/catch/finally

This should be enough.

Comment 4

[[:fabrice] Fabrice Desré]

Alexandre, can you tell us what this means from a user perspective?

Comment 5

[:gerard-majax]

You can't switch to Orange in white areas in France, for example.

Comment 6

[:gerard-majax]

Also see bug 793111

Comment 7

[:gerard-majax]

Also see bug 793111

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 690328 [details] [diff] [review]
Removing the try/catch/finally

Review of attachment 690328 [details] [diff] [review]:
-----------------------------------------------------------------

Please move this trivial patch to bug 819790. They are all follow-up fixes of bug 793111 and bug 819790 provides test cases.