Closed Bug 819790 Opened 12 years ago Closed 11 years ago

B2G RIL: Number of PLMN entries to read

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
blocking-basecamp +
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: gerard-majax, Assigned: kk1fff)

References

Details

Attachments

(1 file, 3 obsolete files)

Bug 793111 introduced PLMN entries reading, taking as argument the number of entries to read. According to the current codebase, I can see the argument is tlvLen/6. As far as I remember, I had the same tlvLen value, but did divide it by 3. I see no justification but the /6, and running tests on my system (Free Mobile SIM card, Nexus S), I get:

with /6:
$ adb logcat | egrep -i "readPLMN"
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN entries length = 1
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [0]: '2,248,16'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN = 208, 1

with /3:
$ adb logcat | egrep -i "readPLMN"
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN entries length = 2
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [0]: '2,248,16'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN = 208, 1
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [1]: '2,248,32'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN = 208, 2

with /2:

$ adb logcat | egrep -i "readPLMN"
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN entries length = 2
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [0]: '2,248,16'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN = 208, 1
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [1]: '2,248,32'
I/Gecko   (   77): RIL Worker: readPLMNEntries: PLMN = 208, 2
I/Gecko   (   77): RIL Worker: readPLMNEntries: Reading PLMN entry: [2]: '255,255,255'

Do you have spec/link suggesting/confirming the /6 value ? All I can find is ETSI spec, TS 131.102, section 4.2.66 which states:
"Note: the length is 3*n bytes, where n denotes the number of PLMN entries. The length can be coded on one or more bytes."
And for your information, 20801 and 20802 are other valid assigned PLMN for Orange network in France, which Free is roaming on.
Attached patch Trivial fix (obsolete) — Splinter Review
Works well on Free Mobile USIM card, and should comply to legacy SIM specifications (but no way for me to test).
20801 is main Orange network identifier, and 20802 is a special one for zones with low coverage and specific multi-operator network to cover at lower cost.
Comment on attachment 690208 [details] [diff] [review]
Trivial fix

Review of attachment 690208 [details] [diff] [review]:
-----------------------------------------------------------------

I think you're right, and we'll still need more test case for this. Please don't check-in now.
Attachment #690208 - Flags: review+
Summary: Number of PLMN entries to read → B2G RIL: Number of PLMN entries to read
Attached file Pull request: change in emulator (obsolete) —
Adding EF_SPDI file, which contains an SPDI TLV (tag: A3) and an Service Provider PLMN List TLV that contains 2 entries: 234136 and 46692.
Assignee: nobody → pwang
Attachment #691754 - Flags: review?(vyang)
Attachment #691759 - Flags: review?(vyang)
Depends on: 819786, 819784
Comment on attachment 691754 [details] [review]
Pull request: change in emulator

Please changes comments of EF_SPDI as well.
Attachment #691754 - Flags: review?(vyang)
Attachment #691759 - Flags: review?(vyang) → review+
No longer depends on: 819786
No longer depends on: 819784
Attached patch PatchSplinter Review
Merged fix from bug 819786 and bug 819784.
Attachment #690208 - Attachment is obsolete: true
Attachment #691754 - Attachment is obsolete: true
Attachment #691759 - Attachment is obsolete: true
Attachment #692191 - Flags: review?(vyang)
Blocks: 821605
Comment on attachment 692191 [details] [diff] [review]
Patch

Review of attachment 692191 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
Attachment #692191 - Flags: review?(vyang) → review+
BB? for bug 819786 and bug 819784 are both bb+.
blocking-basecamp: --- → ?
https://hg.mozilla.org/mozilla-central/rev/d72d915e308b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #12)
> BB? for bug 819786 and bug 819784 are both bb+.

Yep, this is a blocker for that reason.
blocking-basecamp: ? → +
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: