819798 - Element.setAttribute(attr, null); now sets the attribute to the string "null" instead of the empty string

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

So far there are two places where this is a problem:
1. The MsgStatusFeedback object's default status is null, so when it is first used the status text displays as "null". Fortunately it gets reset to "" on line 340.
2. The email address nodes are set to values returned from the message header parser, which returns null when the address does not have the requested component. The "null" value is then read back from the attributes in various places.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Karsten Düsterloh]

Can you elaborate a bit on "now"?
All I find is bug 667856, and it hasn't even been near check-in yet?

Comment 3

[[e-mail]]

(In reply to Karsten Düsterloh from comment #2)
> Can you elaborate a bit on "now"?
It's a regression, so as per standard practice I put the bug that caused the regression in the "Blocks" field. Also the "Depends on" field is the Thunderbird version of the bug, which includes a bit more information, e.g. in the 21st comment thereof.

Comment 4

[Masatoshi Kimura [:emk]]

Now setAttribute() stringify the values because of the Paris bindings migration. So nsIDOMElement doesn't matter.

Comment 5

[[e-mail]]

Pushed comm-central changeset 6d365fc51d1e.