819858 - Cannot get telephony channel change when calling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

This is follow up of bug 811222 and bug 815445.

The audio-channel-changed event is expected to be got with 'telephony' when on a call.

This blocks bug 810780 but I had a workaround in gaia. Anyway this should be fixed.

Comment 1

[Walter Chen[:ypwalter][:wachen]]

This should be P1 bb+ due to blocking of a P1 bb+ bug (C2).
Anyone who can take this, please take this asap.

Comment 2

[Marco Chen [:mchen]]

Attachment: v1

1. The root cause of original code is that audio-change-event is triggered by AudioChannelService::UnregisterType(). But new API for telephony just changed the ref count of telephony channel but not do Register/UnregisterType(). So no event will be fired.

2. This patch tried to use AudioChannelAgent to instead of new APIs so this way will trigger the Register/UnregsiterType() then event will be fired.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 690344 [details] [diff] [review]
v1

Review of attachment 690344 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioManager.cpp
@@ +304,5 @@
>  
>    mPhoneState = aState;
> +
> +  if (aState == PHONE_STATE_IN_CALL) {
> +    mPhoneAudioAgent = do_CreateInstance("@mozilla.org/audiochannelagent;1");

What about:

if (aState == PHONE_STATE_IN_CALL) {
  if (!mPhoneAudioAgent) {
    mPhoneAudioAgent = do_CreateInstance("@mozilla.org/audiochannelagent;1");
    MOZ_ASSERT(mPhoneAudioAgent);
    // Telephony doesn't be paused by any other channels.
    mPhoneAudioAgent->Init(AUDIO_CHANNEL_TELEPHONY, nullptr);
  }

  // Telephony can always play.
  bool canPlay;
  mPhoneAudioAgent->StartPlaying(&canPlay);
} else if (mPhoneAudioAgent) {
  ...
}

Comment 4

[Marco Chen [:mchen]]

Attachment: patch CheckInVersion

Add reviewer and blocking-basecamp

Comment 5

[Marco Chen [:mchen]]

Attachment: patch CheckInVersion

Following comment.

Comment 6

[Marco Chen [:mchen]]

Attachment: patch CheckInVersion

Removing blanking.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a2c761e196c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7a2c761e196c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3bdca8193789
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c645fa53e941