Closed Bug 820053 Opened 7 years ago Closed 7 years ago

Theme's icon.png is not installed properly

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #690473 - Flags: review?(ted)
Assignee: nobody → mh+mozilla
Comment on attachment 690473 [details] [diff] [review]
Properly install browser theme's icon

Review of attachment 690473 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/gnomestripe/Makefile.in
@@ +13,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
>  
> +ICON_FILES := icon.png
> +ICON_DEST := $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}

$(MOZ_APP_ID) would probably be more readable here.
Attachment #690473 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 690473 [details] [diff] [review]
> Properly install browser theme's icon
> 
> Review of attachment 690473 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/gnomestripe/Makefile.in
> @@ +13,5 @@
> >  
> >  include $(topsrcdir)/config/rules.mk
> >  
> > +ICON_FILES := icon.png
> > +ICON_DEST := $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
> 
> $(MOZ_APP_ID) would probably be more readable here.

MOZ_APP_ID is ec8030f7-c20a-464f-9b0e-13a3a9e97384. 972ce4c6-7e08-4474-a285-3208198ce6fd is the theme id.
Apparently I didn't read that well. :)
This version actually works. Required changes: move the definition before including rules.mk, and replace := with = for ICON_DEST because it uses FINAL_TARGET which is only defined in config.mk (included from rules.mk).
Attachment #690473 - Attachment is obsolete: true
Depends on: 820289
Depends on: 820351
Comment on attachment 690771 [details] [diff] [review]
Properly install browser theme's icon.

Carrying over r+
Attachment #690771 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e602d45eef10
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 20 → mozilla20
You need to log in before you can comment on or make changes to this bug.