Closed
Bug 820053
Opened 13 years ago
Closed 13 years ago
Theme's icon.png is not installed properly
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.60 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #690473 -
Flags: review?(ted)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
||
Comment 2•13 years ago
|
||
Comment on attachment 690473 [details] [diff] [review]
Properly install browser theme's icon
Review of attachment 690473 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/gnomestripe/Makefile.in
@@ +13,5 @@
>
> include $(topsrcdir)/config/rules.mk
>
> +ICON_FILES := icon.png
> +ICON_DEST := $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
$(MOZ_APP_ID) would probably be more readable here.
Attachment #690473 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 690473 [details] [diff] [review]
> Properly install browser theme's icon
>
> Review of attachment 690473 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: browser/themes/gnomestripe/Makefile.in
> @@ +13,5 @@
> >
> > include $(topsrcdir)/config/rules.mk
> >
> > +ICON_FILES := icon.png
> > +ICON_DEST := $(FINAL_TARGET)/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}
>
> $(MOZ_APP_ID) would probably be more readable here.
MOZ_APP_ID is ec8030f7-c20a-464f-9b0e-13a3a9e97384. 972ce4c6-7e08-4474-a285-3208198ce6fd is the theme id.
|
|
||
Comment 4•13 years ago
|
||
Apparently I didn't read that well. :)
|
|
Assignee | |
Comment 5•13 years ago
|
||
This version actually works. Required changes: move the definition before including rules.mk, and replace := with = for ICON_DEST because it uses FINAL_TARGET which is only defined in config.mk (included from rules.mk).
|
|
Assignee | |
Updated•13 years ago
|
Attachment #690473 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 690771 [details] [diff] [review]
Properly install browser theme's icon.
Carrying over r+
Attachment #690771 -
Flags: review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Updated•7 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•7 years ago
|
Target Milestone: Firefox 20 → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•