820351 - Switch to native touch for config/makefiles/autotargets.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

With bug 820053 and bug 820289, we end up running:
   touch -t 198001030000 "../../../dist/bin/browser/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/.mkdir.done"

which fails with the following error:
  touch: cannot touch `../../../dist/bin/browser/extensions/972ce4c6-7e08-4474-a285-3208198ce6fd/.mkdir.done': No such file or directory

Once again, we're being hit by msys' handling of command lines. It turns out msys programs are doing {} expansion themselves, instead of the shell doing it. So when executing touch {a}, what touch considers is a, and when executing touch {a,b}, what touch considers is a and b. This doesn't happen when executing win32 executables (tested with cl).

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add support for -t option of touch in pymake builtins

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use pymake native touch in config/makefiles/autotargets.mk

Comment 3

[Mike Hommey [:glandium]]

Attachment: Add support for -t option of touch in pymake builtins

Better without a debug print.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 690845 [details] [diff] [review]
Add support for -t option of touch in pymake builtins

Review of attachment 690845 [details] [diff] [review]:
-----------------------------------------------------------------

This could stand a unit test or two.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Add a pymake unit test for native touch -t

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcec67acfda3
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5953a0cbf7
https://hg.mozilla.org/integration/mozilla-inbound/rev/500855f76d16

Comment 7

[Mike Hommey [:glandium]]

http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/18f568d238ef
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/5af2e1fd3328

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dcec67acfda3
https://hg.mozilla.org/mozilla-central/rev/8b5953a0cbf7
https://hg.mozilla.org/mozilla-central/rev/500855f76d16

Comment 9

[Daniel Holbert [:dholbert]]

For some reason, this change triggered this output for me & others (e.g. snorp) when doing a pull -u:
> $ hg pull -u
> pulling from https://hg.mozilla.org/mozilla-central/
> searching for changes
> adding changesets
> adding manifests
> adding file changes
> added 289 changesets with 1187 changes to 792 files
> not updating: path contains illegal component: /pymake/tests/native-touch.mk
> $ hg --version
> Mercurial Distributed SCM (version 2.2.2)

The workaround is to run "hg up --clean -r default", but it'd be good to figure out what happened here that's triggering the problem.

Comment 10

[Daniel Holbert [:dholbert]]

Specifically, that seems to be the last change -- 500855f76d16 -- which triggered this.
(That's the change that added build/pymake/tests/native-touch.mk.)

I hit this on 64-bit Linux (Ubuntu 12.10); snorp hit it on Mac.