820150 - FTE : Tutorial needs to be translated for the graphics or have images that do not have english in it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
Unagi phone, build 2012-12-9

## Repro :
1. set language to a P1 language
2. run through the first run experience
3. launch the tutorial

## Expected :
1. tutorial should be in the selected language

## Actual :
1. English is shown

## Note :
1. seperating from bug 819960

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P1 - tutorial in wrong lanaguage is not useful for users

Comment 2

[Fernando Campo (:fcampo)]

Yup, discovered that even though strings are localizad, l10n tags are not used. 

Taking care of it together with #818588 and #813302

Comment 3

[Fernando Campo (:fcampo)]

Attachment: Link to Will get fixed when https://github.com/mozilla-b2g/gaia/pull/6999 gets approved (asking for revisions to the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=820150

This fixes the translations, but with the new assets provided by UX

Would solve at the same time bug 813302, bug 818350 and bug 818588 (all tutorial related)

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 691868 [details]
Link to Will get fixed when https://github.com/mozilla-b2g/gaia/pull/6999 gets approved (asking for revisions to the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=820150

From an l10n pov, I think we want to nail down the copy before landing this. I've tried to rally help in bug 818588.

Comment 5

[Fernando Campo (:fcampo)]

Comment on attachment 691868 [details]
Link to Will get fixed when https://github.com/mozilla-b2g/gaia/pull/6999 gets approved (asking for revisions to the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=820150

Final strings decided in bug 818588 (at last!), so we can keep going with the review :)

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 691868 [details]
Link to Will get fixed when https://github.com/mozilla-b2g/gaia/pull/6999 gets approved (asking for revisions to the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=820150

r=me.

The only caveat I have would be a comment for RTL locales if "right" is "right" or "left", i.e., if we're ordering the screens in RTL or LTR for a RTL locale.

Given that we don't have an active RTL locale, and it'd be a comment only, that's not blocking, though.

Comment 7

[Fernando Campo (:fcampo)]

And merged! https://github.com/mozilla-b2g/gaia/commit/d85fdfc8cb9d70b264321e633a047f66dcbbcea2

About the RTL issue, I wouldn't worry for now, as we don't have either CSS rules for it (when I say not to worry, I mean that all the RTL issues will be probably brought up together in the future, when we are in disposition of taking care of them)

Comment 8

[Matt Wobensmith [:mwobensmith][:matt:]]

The issue with non-localized graphics is captured in bug 828276.

Localized text in tutorial confirmed fixed in build 20130110070201 using ES locale.