820179 - Mach command for `make package`

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Does exactly what it says on the tin.

I'm probably missing something (first Mach contrib), so feedback welcome.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 690606 [details] [diff] [review]
Proposed patch. v1

Review of attachment 690606 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +130,5 @@
>                      warning['flag'], warning['message']))
>  
> +@CommandProvider
> +class Package(MachCommandBase):
> +    """Package an APK for Android."""

Is this really Android-specific? I thought we had make package for desktop too.

Comment 2

[Mike Hommey [:glandium]]

(In reply to :Ms2ger from comment #1)
> Is this really Android-specific? I thought we had make package for desktop
> too.

It's not, we use make package to create the windows zip, the mac dmg and the linux tarballs.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v2

Ah, didn't realize it was overloaded. (I've never used `package` for desktop; it seems to be done automatically, at least on my Mac.)

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 690917 [details] [diff] [review]
Proposed patch. v2

Review of attachment 690917 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: python/mozbuild/mozbuild/mach_commands.py
@@ +134,5 @@
> +    """Package the built product for distribution."""
> +
> +    @Command('package', help='Package the built product for distribution as an APK, DMG, etc.')
> +    def package(self):
> +        self._run_make(directory=".", target='package')

return self._run_make(directory='.', target='package', ensure_exit_code=False)

Otherwise you get a fat exception if |make| exits non-0.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/740c8dd81b04

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/740c8dd81b04