Open Bug 820313 Opened 12 years ago Updated 2 years ago

The visibility of the FMRadio component can be depend by more than 1 app

Categories

(Core :: DOM: Core & HTML, defect, P5)

defect

Tracking

()

People

(Reporter: baku, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Attachment #690838 - Flags: review?(rlin)
OS: Linux → All
Hardware: x86_64 → All
I forgot to change the UUID of the IDL but I'll wait for comments before submitting a new patch.
Hm, we had planned to review this for bug 820241.  There are many bad things that multiple clients can do right now.  But this is fine.
Although on second thought I'm not sure this patch is going to improve the experience of multiple apps trying to use the radio concurrently.
This patch it's just about the usage of the content audio channel if multiple apps use the radio concurrently.
Comment on attachment 690838 [details] [diff] [review]
patch

I don't have the right to set r+, transfer to proper one.
Maybe only allow one client to use fmradio is better for avoiding such kind of competition.
Attachment #690838 - Flags: review?(rlin) → review?(jones.chris.g)
Andrea, do you think this code has value while we await bug 820241?  What use cases do you have in mind?
Flags: needinfo?(amarchesini)
> Maybe only allow one client to use fmradio is better for avoiding such kind
> of competition.

If we do this, this patch is not needed.
In general, my concern is that multiple apps can use FMRadio but the visibility is a boolean flag set by one of them.
Flags: needinfo?(amarchesini)
That's true, but the enabled-ness and channel are also set by one of them.

If you don't have some use cases in mind, I'd prefer we take this patch as a starter for bug 820241 :).
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
Component: DOM → DOM: Core & HTML
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: