82041 - Clicking on Search button the first time reverts pref to Netscape Search

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P2)

Description

[Olivier Crête]

My search preferences are set to google. When I start moz and type something in
the url bar, the autocomplete appears and it has the google logo, so its still
pointing to google. But when I click on the Search button, it goes right to
search.netscape.com and the search pref is reset to netscape search. This might
be related to bug 60283.

Comment 1

[matt]

Put your vote in on 82041

*** This bug has been marked as a duplicate of 60283 ***

Comment 2

[Olivier Crête]

I believe this is not the same as bug 60283. First, bug 60283 seems to specify
that it only happens when nothing has been changed in the URL bar. This is not
the case here, I have written something in there. And it happens only once per
session.

Comment 3

[matt]

sorry about that.  You are right.  Claudius I think filed a bug against me on 
this.  It might have something to do with you search button disappearing.  Did 
that happen?

Comment 4

[Olivier Crête]

Search button never disapears. 

Comment 5

[Claudius Gayle]

Matt, this _is_ what I was seeing before. The key is that is happens only the first time.

Repro:

1. Select Edit|Preferences|Navigator|Internet Search and change your search provider to Google.
2. Quit and restart the browser. (Is the goof right here or later?)
3. Type something in the url bar preferably somethat will autocomplete. You should notice
that the autocomplete search indicates it is set to google.
4. Now click the search button to the right of the URL bar.

You get a netscape search on your search term! Evil!
the change is thorugh and sticky. The autocomplete widget will now indicate the Netscape search
and even the preference window will show that you've selected 'Netscape Search'.

Confirmed with 2001052208 builds

Comment 6

[Viswanath Ramachandran]

nav triage: yes we saw this too. accepting for mozilla0.9.2. p2. 

Comment 7

[Ben Bucksch (:BenB)]

This bug makes search functionality unusable.

For me, the bug manifests itself in the following way:
I set the pref to Google. I enter a search term, click "Search". Google is
indeed used. But all subsequent searches will go to Netscape. Repeat. I.e. the
bug does *not* only appear once per session for me.

Does it happen with 0.9.1? I'd argue that this might be a release blocker then.

Comment 8

[Claudius Gayle]

*** Bug 83148 has been marked as a duplicate of this bug. ***

Comment 9

[[e-mail]]

Ben says "Does it happen with 0.9.1? I'd argue that this might be a release
blocker then."

Yes, 2001052908 Linux. I no longer use Mozilla's search feature in current
builds because it's too b0rked to be worth fighting with.

I'd be happy to see a 24 hour slip for just this, so long as the fix was
permanent and I didn't have to look forward to matt breaking it again.

Comment 10

[matt]

summary:  either the autocomplete or the search button is reverting the search 
back to the default.   Need to investigate further.
days:1
need to fix

Comment 11

[matt]

Attachment: patch for prefs idl to be added

Comment 12

[matt]

Need reviews....

Blake? Mcafee?

Comment 13

[Blake Ross]

mPrefs doesn't seem to be declared anywhere.  Can't we make it a global 
and then retrieve it and cache it the first time we need it (since it seems to 
be called on each search)?

Comment 14

[matt]

we could do that.  I'm not huge on the global person.
We do that for  
var pref = Components.classes["@mozilla.org/preferences;1"]
                     .getService(Components.interfaces.nsIPref);

but here i'm using nsIPrefBranch and only reference it twice.
If we move everything over to branch...which we should
we definitely should be doing this.

Blake,

Ur mr. s......you make the call.  I'm to tired.


But i should add a var mPref =
otherwise is could get declared as global.

Comment 15

[[e-mail]]

*** Bug 85034 has been marked as a duplicate of this bug. ***

Comment 16

[Chris Hiner]

*** Bug 83932 has been marked as a duplicate of this bug. ***

Comment 17

[Viswanath Ramachandran]

adding pdt+ as per pdt discussion, this bug was nearly a m0.9.1 stopper. 

Comment 18

[Viswanath Ramachandran]

sorry I made that comment in a wrong bug. the near-stopper was another bug. in
any case, this bug is an rtm stopper - Matt please check in the fix with r/sr. 

Comment 19

[matt]

blake gives a r=matt

Comment 20

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 21

[Chris McAfee]

r=mcafee too

Comment 22

[matt]

r=matt

Comment 23

[R.K.Aa.]

*** Bug 85870 has been marked as a duplicate of this bug. ***

Comment 24

[Claudius Gayle]

VERIFIED Fixed with 2001061415 builds on all platforms