Closed
Bug 820711
Opened 12 years ago
Closed 12 years ago
[FTE] No counter of PIN attempts
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)
Firefox OS Graveyard
Gaia::First Time Experience
All
Gonk (Firefox OS)
Tracking
(blocking-basecamp:+)
People
(Reporter: askeing, Assigned: mbudzynski)
References
Details
(Keywords: late-l10n)
Attachments
(1 file)
Tested with unagi_2012-12-11_eng.zip.
In the FTU app, the PIN lock interface does not have counter of PIN attempts.
It should be important.
Thanks.
ref:
Bug 818172
|
Reporter | |
Comment 1•12 years ago
|
||
It should be a P1 blocking issue as well.
blocking-basecamp: --- → ?
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → All
|
|
Reporter | |
Updated•12 years ago
|
Summary: [FTU] No counter of PIN attempts → [FTE] No counter of PIN attempts
|
||
Comment 3•12 years ago
|
||
adding Peter to see if he can also provide a response
Flags: needinfo?(pdolanjski)
|
||
Updated•12 years ago
|
Flags: needinfo?(dcoloma)
|
||
Comment 4•12 years ago
|
||
This was considered a blocker for the "regular" switch-on (without FTE) in bug 820711 so I think this should be a blocker as the problem is the same.
Flags: needinfo?(dcoloma)
|
||
Comment 5•12 years ago
|
||
Agree, we should be consistent here with the normal PIN lock. Let's mark bb+.
Flags: needinfo?(clee)
|
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
Priority: -- → P1
|
||
Updated•12 years ago
|
Flags: needinfo?(pdolanjski)
|
|
||
Updated•12 years ago
|
Assignee: nobody → fbsc
|
||
Updated•12 years ago
|
Target Milestone: --- → B2G C3 (12dec-1jan)
|
||
Updated•12 years ago
|
Assignee: fbsc → fernando.campo
|
Assignee | |
Updated•12 years ago
|
Assignee: fernando.campo → mbudzynski
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #693579 -
Flags: review?(fernando.campo)
|
|
||
Updated•12 years ago
|
Blocks: b2g-v1-certification
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 693579 [details]
patch
Sorry, can't approve until regression issues are solved (comments in github). Please rebase and fix them, and update the pull request :)
Attachment #693579 -
Flags: review?(fernando.campo) → review-
|
|
Assignee | |
Updated•12 years ago
|
Attachment #693579 -
Flags: review- → review?(fernando.campo)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Patch fixed - changes before were based on commit from 15/12, my fault.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #693579 -
Flags: review?(stas)
|
|
Assignee | |
Comment 9•12 years ago
|
||
[:fcampo] conflict resolved.
|
||
Comment 10•12 years ago
|
||
Comment on attachment 693579 [details]
patch
Is the current wording "The PIN was incorrect." correct? I'm not a native speaker, so it's hard for me to judge.
In any case, this looks good l10n-wise. r=me.
Attachment #693579 -
Flags: review?(stas) → review+
|
|
||
Updated•12 years ago
|
Attachment #693579 -
Flags: review?(fernando.campo) → review+
|
||
Comment 11•12 years ago
|
||
Before merging there is a little typo in the code. a = that should be - to fix before landing ;)
|
|
Assignee | |
Comment 12•12 years ago
|
||
fixed
|
|
||
Comment 13•12 years ago
|
||
Merging https://github.com/mozilla-b2g/gaia/commit/54d7c73ca99dff3fd2efae1552152d4f1434342b
Sorry for not waiting for you to do it michalbe, but need it merged asap to avoid conflicts on the next PR
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 14•12 years ago
|
||
device: unagi
build: unagi_2012-12-24 from https://releases.mozilla.com/b2g/
Verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•