821033 - TestFile fails on Android: "main Creating temp directory, rv=80004005"

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

With the patch for bug 811411, we can run unit tests on Android...but some tests fail.

TestFile fails consistently with:

Running nsLocalFile tests...
TEST-UNEXPECTED-FAIL | main Creating temp directory, rv=80004005
Finished running nsLocalFile tests.
remotecppunittests TEST-UNEXPECTED-FAIL | TestFile | test failed with return code 1

Comment 1

[Geoff Brown [:gbrown]]

...but it passes just fine if we simply define a TMPDIR environment variable:

Running nsLocalFile tests...
TEST-PASS | Setup
TEST-PASS | AppendNative with invalid file name
TEST-PASS | GetParent
TEST-PASS | Create file
TEST-PASS | Remove file
TEST-PASS | Create directory
TEST-PASS | MoveTo rename file
TEST-PASS | CopyTo copy file
TEST-PASS | MoveTo move file
TEST-PASS | MoveTo move and rename file
TEST-PASS | CopyTo copy file across directories
TEST-PASS | Normalize with native paths
TEST-PASS | Remove directory
TEST-PASS | CreateUnique file
TEST-PASS | CreateUnique directory
TEST-PASS | OpenNSPRFileDesc DELETE_ON_CLOSE
Finished running nsLocalFile tests.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: define TMPDIR and HOME in unit test env

Define TMPDIR in environment. 

I have also seen problems in xpcshell tests when HOME is not defined, so adding that as well.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 691526 [details] [diff] [review]
define TMPDIR and HOME in unit test env

Review of attachment 691526 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/remotecppunittests.py
@@ +79,5 @@
>      def buildEnvironment(self):
>          env = self.buildCoreEnvironment( {} )
>          env['LD_LIBRARY_PATH'] = self.remoteBinDir
> +        env["TMPDIR"]=self.remoteTmpDir
> +        env["HOME"]=self.remoteTmpDir

You might want to make TMPDIR and HOME not point to the same directly, working on theory that this would make the execution environment for the unit tests more like the execution environment Fennec is likely to run under.

In practice, I'm not convinced this is likely to be a problem in real life, so r=dmose with or without that change.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

One thing that occurs to me after the fact is that for the tests I'm running, MOZ_WEBRTC_TESTS must be set to 1 in the environment.  So maybe there really wants to be a more generic hook for setting environment variables on the target.

Comment 5

[Geoff Brown [:gbrown]]

(In reply to Dan Mosedale (:dmose) from comment #4)
> One thing that occurs to me after the fact is that for the tests I'm
> running, MOZ_WEBRTC_TESTS must be set to 1 in the environment.  So maybe
> there really wants to be a more generic hook for setting environment
> variables on the target.

Filed bug 821425 for this.

Comment 6

[Geoff Brown [:gbrown]]

Attachment: define TMPDIR and HOME in remote unit test env

Updated as suggested in comment 3. r=dmose

Comment 7

[Geoff Brown [:gbrown]]

Attachment: define TMPDIR and HOME in remote unit test env

Re-based for new patch on bug 811411.

Comment 8

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79e3ae509764

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/79e3ae509764