821155 - [Everything.me] The behavior of value selector in e.me is very unexpected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P3)

Description

[John Shih]

## Environment :
Unagi phone, build 2012-12-13
Build info: 
gaia master : dc02bffefc3caa1e1b435b3d417ed80897947a49
mozilla-beta : baf41da2066b

## Repro :
1. Move the e.me
2. Make sure internet connection and press "More" button
3. Select and unselect arbitrary selection several time
4. Press "OK"

## Expected:
* If leave with the selection is selected, I'll see the selection will be added in the page, otherwise I won't see any selection is added

## Actual:
* Multiple same selections will be added, no matter leave with selection selected or unselected

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: Can you clarify what step 3 means? thanks 
3. Select and unselect arbitrary selection several time

Comment 2

[John Shih]

more detail steps:
1. press more
2. see the list
3. press on a selection to select it (e.g, top apps)
4. press the selection as same step 3. again
5. repeat 3&4 several times
6. press ok

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Value selector issue, goes to Rudy.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Here is the proposal to handle this issue before we have a final decision from Bug 819619.

Proposed Solution
=================

1. For single select, 
   - Change the value selector behavior back to the original one,
     i.e., have [OK] and [Cancel] button and the change event would occur after [OK] is clicked.

2. For single select with [size > 1] and multiple select, use the current implementation that change event would be triggered immediately after the option is clicked.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 7050

Instead of modifying the standard behavior of <select>, we can wait for OK button to be pressed before adding shortcuts.

Comment 6

[Dietrich Ayala (:dietrich)]

Driver retriage: Not holding the release for this. Would take patch on approval once reviewed.

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 693071 [details]
Pull request 7050

perfect for me

Comment 8

[Alexandre Poirot [:ochameau]]

Comment on attachment 693071 [details]
Pull request 7050

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: Tested e.me addition of apps.
Risk to taking this patch (and alternatives if risky):
Limited to addition/removal of app category in e.me. <select> haven't been modified.

It isn't very clear why we have to justify landing C3 bugs??
Should we work on them at all?

Comment 9

[Alexandre Poirot [:ochameau]]

It appears that this bug was a duplicate of bug 820728 and has been fixed by:
https://github.com/mozilla-b2g/gaia/commit/825be6569e1141f281d091182bb7517d09b815c5

Comment 10

[John Shih]

verified on unagi
build info
12/27
gaia master: a698a8b4018d5e98008ae4ca91bf0ad49c5591ad
b2g-18: 2008afe879e6