821303 - Need a switch to default content in marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

To be able to tell the browser to switch away to the default content (probably the top frame) so am splitting this from bug 814768.

We can just add the listener to bug 814786 and where it is switched to in this bug.

Comment 1

[David Burns :automatedtester]

I just realised we do have this but we should add the selenium helper methods of switch_to_default_content which does the same thing.

Removed the blocker

Comment 2

[David Burns :automatedtester]

We just need to add helper method to the Marionette object.

marionette.switch_to_default_content() which then just calls self.switch_to_frame()

Comment 3

[Atul Jangra [:atuljangra]]

Can I get some pointers on this bug, I want to try this one. :-)

Comment 4

[Rohit]

(In reply to David Burns :automatedtester (PTO until 02/01/2013) from comment #2)
> We just need to add helper method to the Marionette object.
> 
> marionette.switch_to_default_content() which then just calls
> self.switch_to_frame()

I would like to work on this bug. Where do i start?

Comment 5

[David Burns :automatedtester]

(In reply to Atul Jangra [:atuljangra] from comment #3)

(In reply to Rohit from comment #4)

Hi!

We are currently looking at changing the method name and how it works. When that discussion is complete will update the bug with more info! Thanks for wanting to help!

Comment 6

[David Burns :automatedtester]

For this we are going to need to a switch_to_frame() (note that there is no argument)

Details are in https://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/frame

and this needs to essentially be a copy of https://code.google.com/p/selenium/source/browse/py/selenium/webdriver/remote/webdriver.py#522

You can port tests from https://code.google.com/p/selenium/source/browse/py/test/selenium/webdriver/common/frame_switching_tests.py that use switch_to_default_content()

Comment 7

[Jarek Śmiejczak [:jotes]]

Hi, from what i see this bug is still assigned to nobody@. I'd like to work on this bug if it's alright for Rohit and David.

Comment 8

[David Burns :automatedtester]

(In reply to Jarek Śmiejczak from comment #7)
> Hi, from what i see this bug is still assigned to nobody@. I'd like to work
> on this bug if it's alright for Rohit and David.

Feel free to start work on it. If Rohit comes back I can look for other tasks for him

David

Comment 9

[Jarek Śmiejczak [:jotes]]

Thanks for response, i'll work on it.

Comment 10

[Jarek Śmiejczak [:jotes]]

Attachment: 0001-Bug-821303-Added-switch_to_default_content-method.patch

I've created method as you suggested and ported test which involved switch_to_default_content().
However, i'm not sure about naming conventions of test-methods inside python tests of marionette (camelcase vs. underscores).
I hope i didn't mess up anything :)

Comment 11

[David Burns :automatedtester]

just going to push this to try before landing

https://tbpl.mozilla.org/?tree=Try&rev=5e281b3dc049
https://tbpl.mozilla.org/?tree=Try&rev=43e7db5c23fb

Comment 12

[David Burns :automatedtester]

try is green, will land

Comment 13

[David Burns :automatedtester]

landed http://hg.mozilla.org/integration/mozilla-inbound/rev/541145278263

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/541145278263

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/73be16f12d92