821344 - test_bug595059.js and test_0081_prompt_uiAlreadyOpen.js update tests fails in B2G due to custom nsIUpdatePrompt

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Andrew Halberstadt [:ahal]]

toolkit/mozapps/update/test/unit/test_0030_general.js
toolkit/mozapps/update/test/unit/test_0081_prompt_uiAlreadyOpen.js
toolkit/mozapps/update/test/unit/test_bug595059.js

Haven't had a chance to look into whether or not they are harness, test or platform problems.

https://tbpl.mozilla.org/php/getParsedLog.php?id=17794511&tree=Cedar

Comment 1

[Robert Strong (they/them - no direct email)]

Filed bug 821919 for test_0030_general.js since the failure appears to be due to the test harness and separate from the rest of the failures.

Comment 2

[Robert Strong (they/them - no direct email)]

test_0081_prompt_uiAlreadyOpen.js shouldn't run for B2G since B2G doesn't use the toolkit -> app update user interface so it is good to go as skipped.

Comment 3

[Robert Strong (they/them - no direct email)]

test_bug595059.js is also toolkit - app update user interface specific which won't pass since gonk takes over nsIUpdatePrompt. The backend portion that test_bug595059.js and test_0081_prompt_uiAlreadyOpen.js also test is also tested by test_bug497578.js without relying on nsIUpdatePrompt which is why that one passes on gonk.

Note: it would be a good thing to get tests for the gonk version of nsIUpdatePrompt if there aren't tests already.

With the above info, this bug is wfm as I see it.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - update reason for skipping test

Forgot to update the reason for skipping the two tests

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf4fc10c92a

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ecf4fc10c92a