test_bug595059.js and test_0081_prompt_uiAlreadyOpen.js update tests fails in B2G due to custom nsIUpdatePrompt

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ahal, Assigned: rstrong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
toolkit/mozapps/update/test/unit/test_0030_general.js
toolkit/mozapps/update/test/unit/test_0081_prompt_uiAlreadyOpen.js
toolkit/mozapps/update/test/unit/test_bug595059.js

Haven't had a chance to look into whether or not they are harness, test or platform problems.

https://tbpl.mozilla.org/php/getParsedLog.php?id=17794511&tree=Cedar
Filed bug 821919 for test_0030_general.js since the failure appears to be due to the test harness and separate from the rest of the failures.
Summary: test_0030_general.js, test_0081_prompt_uiAlreadyOpen.js and test_bug595059.js update tests fail in B2G → test_0081_prompt_uiAlreadyOpen.js and test_bug595059.js update tests fail in B2G
test_0081_prompt_uiAlreadyOpen.js shouldn't run for B2G since B2G doesn't use the toolkit -> app update user interface so it is good to go as skipped.
Summary: test_0081_prompt_uiAlreadyOpen.js and test_bug595059.js update tests fail in B2G → test_bug595059.js update test fails in B2G
test_bug595059.js is also toolkit - app update user interface specific which won't pass since gonk takes over nsIUpdatePrompt. The backend portion that test_bug595059.js and test_0081_prompt_uiAlreadyOpen.js also test is also tested by test_bug497578.js without relying on nsIUpdatePrompt which is why that one passes on gonk.

Note: it would be a good thing to get tests for the gonk version of nsIUpdatePrompt if there aren't tests already.

With the above info, this bug is wfm as I see it.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
Forgot to update the reason for skipping the two tests
Assignee: nobody → robert.bugzilla
Status: RESOLVED → REOPENED
Attachment #692538 - Flags: review?(ahalberstadt)
Resolution: WORKSFORME → ---
Status: REOPENED → ASSIGNED
Summary: test_bug595059.js update test fails in B2G → test_bug595059.js and test_0081_prompt_uiAlreadyOpen.js update tests fails in B2G due to custom nsIUpdatePrompt
(Reporter)

Updated

6 years ago
Attachment #692538 - Flags: review?(ahalberstadt) → review+
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf4fc10c92a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.