Use proper modules dir for b2g xpcshell tests

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rstrong, Assigned: ahal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozharness][unittest])

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #821344 +++
This test is failing at
Components.utils.import("resource://testing-common/httpd.js");

with
19:18:48  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: /data/local/tests/xpcshell/toolkit/mozapps/update/test/unit/head_update.js :: start_httpserver :: line 2581"  data: no]

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/head_update.js.in#1691

https://tbpl.mozilla.org/php/getParsedLog.php?id=17794511&tree=Cedar

This is likely a test harness bug
Summary: test_0030_general.js update test fail in B2G → test_0030_general.js update test fail in B2G with NS_ERROR_FILE_NOT_FOUND when calling Components.utils.import("resource://testing-common/httpd.js");
Summary: test_0030_general.js update test fail in B2G with NS_ERROR_FILE_NOT_FOUND when calling Components.utils.import("resource://testing-common/httpd.js"); → test_0030_general.js update test fails in B2G with NS_ERROR_FILE_NOT_FOUND when calling Components.utils.import("resource://testing-common/httpd.js");
No longer depends on: 821344
Sounds like the testing module path isn't being set correctly, which is where httpd.js lives.
Ok, I'm a bit confused:
> [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls modules
> httpd.js  services  services-common
>
> [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls xpcshell/tests/modules
> libjar  libpref

Currently xpcshell is running with:
> --testing-modules-dir xpcshell/tests/modules

So what you said about httpd.js not being found makes sense. But it seems that the libjar and libpref directories are needed for any test to run whatsoever. So changing it to ../modules will just introduce new failures? How is this supposed to get setup?
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Ok, I'm a bit confused:
<...>
> > [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls xpcshell/tests/modules
> > libjar  libpref

Those are just names of source directories:
http://mxr.mozilla.org/mozilla-central/source/modules/libpref/
http://mxr.mozilla.org/mozilla-central/source/modules/libjar/
Created attachment 693613 [details] [diff] [review]
Patch 1.0 - Use proper modules dir for b2g xpcshell

Ah, I see what was happening. Not specifying --testing-modules-dir at all results in xpcshell harness errors which you can work around by passing in any arbitrary directory. I assumed that since passing in tests/modules fixed the problem I had the right directory. This is agains mozharness
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #693613 - Flags: review?(ted)
Component: XPCShell Harness → Release Engineering: Automation (General)
Product: Testing → mozilla.org
QA Contact: catlee
Summary: test_0030_general.js update test fails in B2G with NS_ERROR_FILE_NOT_FOUND when calling Components.utils.import("resource://testing-common/httpd.js"); → Use proper modules dir for b2g xpcshell tests
Version: unspecified → other
Whiteboard: [mozharness][unittest]
Comment on attachment 693613 [details] [diff] [review]
Patch 1.0 - Use proper modules dir for b2g xpcshell

Review of attachment 693613 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really know this mozharness code, but this sounds right.
Attachment #693613 - Flags: review?(ted) → review+
https://hg.mozilla.org/build/mozharness/rev/6660a5da06ca
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Forgot to re-enable the test
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 693913 [details] [diff] [review]
re-enable test_0030_general.js
Attachment #693913 - Flags: review?(robert.bugzilla)
Attachment #693913 - Flags: review?(robert.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/541c69c0b116
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.