821919 - Use proper modules dir for b2g xpcshell tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

+++ This bug was initially created as a clone of Bug #821344 +++
This test is failing at
Components.utils.import("resource://testing-common/httpd.js");

with
19:18:48  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell/head.js | [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: /data/local/tests/xpcshell/toolkit/mozapps/update/test/unit/head_update.js :: start_httpserver :: line 2581"  data: no]

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/test/unit/head_update.js.in#1691

https://tbpl.mozilla.org/php/getParsedLog.php?id=17794511&tree=Cedar

This is likely a test harness bug

Comment 1

[(not currently active) Ted Mielczarek]

Sounds like the testing module path isn't being set correctly, which is where httpd.js lives.

Comment 2

[Andrew Halberstadt [:ahal]]

Ok, I'm a bit confused:
> [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls modules
> httpd.js  services  services-common
>
> [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls xpcshell/tests/modules
> libjar  libpref

Currently xpcshell is running with:
> --testing-modules-dir xpcshell/tests/modules

So what you said about httpd.js not being found makes sense. But it seems that the libjar and libpref directories are needed for any test to run whatsoever. So changing it to ../modules will just introduce new failures? How is this supposed to get setup?

Comment 3

[(not currently active) Ted Mielczarek]

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Ok, I'm a bit confused:
<...>
> > [~/git/B2G/objdir-gecko/dist/test-package-stage]$ ls xpcshell/tests/modules
> > libjar  libpref

Those are just names of source directories:
http://mxr.mozilla.org/mozilla-central/source/modules/libpref/
http://mxr.mozilla.org/mozilla-central/source/modules/libjar/

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Use proper modules dir for b2g xpcshell

Ah, I see what was happening. Not specifying --testing-modules-dir at all results in xpcshell harness errors which you can work around by passing in any arbitrary directory. I assumed that since passing in tests/modules fixed the problem I had the right directory. This is agains mozharness

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 693613 [details] [diff] [review]
Patch 1.0 - Use proper modules dir for b2g xpcshell

Review of attachment 693613 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really know this mozharness code, but this sounds right.

Comment 6

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/build/mozharness/rev/6660a5da06ca

Comment 7

[Andrew Halberstadt [:ahal]]

Forgot to re-enable the test

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: re-enable test_0030_general.js

Comment 9

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/541c69c0b116

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/541c69c0b116