821703 - Unable to flash phone Flashing out/target/product/otoro/system.img failed because the image was too large.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Casey Yee]

using build from:
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-otoro/latest/otoro.zip

Device no longer boots :/

ERROR: Unable to create a plug-in (e00002be)
< waiting for device >
erasing 'cache'...
OKAY [  0.389s]
finished. total time: 0.389s
erasing 'userdata'...
OKAY [  0.990s]
finished. total time: 0.990s
sending 'userdata' (4 KB)...
OKAY [  0.003s]
writing 'userdata'...
OKAY [  0.993s]
finished. total time: 0.996s
sending 'system' (124985 KB)...
FAILED (remote: data too large)
finished. total time: 0.001s

Flashing out/target/product/otoro/system.img failed because the image was too large.
Try re-flashing after running
  $ rm -rf out/target/product/otoro/data && ./build.sh

Comment 1

[Casey Yee]

Still having issues with todays build 2012-12-17

Comment 2

[Lucas Adamski [:ladamski]]

I'm having the same issue.  Did we regress bug 821296?

Comment 3

[Casey Yee]

I'm getting the same issue still with the Otoro device.

I officially have no device to work with since my unagi touch sensor borked out on me :/

Comment 4

[Gabriele Svelto [:gsvelto]]

The otoro.zip file grew 5MiB all of a sudden, I'll check it out tomorrow and see if we've regressed because of the same reason or if the extra bloat comes from somewhere else. I'm taking this one.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We just added the maps app package to the installation.

As I recall we had 12MB of unused junk we could cut, so I guess we should do that now ;).

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also, fwiw, my local otoro "user" builds flash just fine.  Has the different in size for multilocal grown since the last measurement?

Comment 7

[Lucas Adamski [:ladamski]]

If this is similar to bug 821296, there we were wasting a lot of space duplicating assets, so it was a build-related issue AFAIK.

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #5)
> We just added the maps app package to the installation.

Yes, that's were the growth is coming from. I could immediately spot some low hanging fruit there: the app is shipping audio files in OGG and MP3 format but only uses the OGG ones on our platform. Changing the code for getting rid of the MP3 files will save ~2.6MiB already but that won't be enough.

On this topic did the gaia team re-compress their assets already? I've added a script under gaia/tools/png_recompress.sh to help with that, invoking it on the gaia tree shaved another ~2MiB off the image last time I tried.

> As I recall we had 12MB of unused junk we could cut, so I guess we should do
> that now ;).

Do you mean the stuff in bug 825142? Unfortunately it seems we can't remove icu4c easily as the base system has some dependencies on it, see my comment there. I'll try to figure out if there's anything else in the B2G manifest that can be removed easily in order to save space.

> Also, fwiw, my local otoro "user" builds flash just fine.  Has the different
> in size for multilocal grown since the last measurement?

Try adding |export MOZILLA_OFFICIAL=1| to your .userconfig; that one pulls in the official logo which weighs at ~3.4MiB and tips the system image size over the limit.

(In reply to Lucas Adamski from comment #7)
> If this is similar to bug 821296, there we were wasting a lot of space
> duplicating assets, so it was a build-related issue AFAIK.

Unfortunately this time it's the new assets, we need another way around it :-(

Comment 9

[Gabriele Svelto [:gsvelto]]

One very ugly hack to shrink the system image is by re-generating the image after having wiped the MP3 files from the maps app with the following command (from the gaia root directory):

zip -d profile/webapps/maps/application.zip fw/audio/mi_audio.mp3 fw/audio/km_audio.mp3

Unfortunately since maps is an external app there's no way to add it to our current build system. I'll try to get in touch with someone who could ask our Nokia contacts if they can get rid of the MP3s for us.

In the meantime I'll further investigate bug 825142 in the hope that some of the Android libraries can go.

Comment 10

[Gabriele Svelto [:gsvelto]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7667

Pointer to Github pull-request

Comment 11

[Gabriele Svelto [:gsvelto]]

Comment on attachment 703363 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7667

The maps app contains identical OGG and MP3 files for voice navigation, in B2G the OGG files are used automatically so the MP3s are redundant. I've modified the pre-existing application.zip file by removing the MP3 files:

- fw/audio/mi_audio.mp3
- fw/audio/km_audio.mp3

I've also adjusted this snippet in combined.js:

m=a.platform.firefox?".ogg":".mp3";

To look like this:

m=".ogg"

This should force the app to always pick the OGG files as an extra safety measure.

Once the MP3 files are gone the system.img file shrinks by ~2.6MiB  and becomes small enough to be flashed on the Otoro again when doing a user/official build.

Comment 12

[Gabriele Svelto [:gsvelto]]

Merged, I'll wait for the releng build to be flashable again before closing:

https://github.com/mozilla-b2g/gaia/commit/227b9017d8213ab9fa871661d6f8b3167ff0ae57

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Please file a bug on the maps app and CC AndyT ([e-mail]).

Comment 14

[Gabriele Svelto [:gsvelto]]

Filed as bug 831930.

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks!

gsvelto, we're still packaging the android media files, /system/media.  It should be a simple manifest change to whack those, and that will save 6.2MB.

Comment 16

[Gabriele Svelto [:gsvelto]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #15)
> gsvelto, we're still packaging the android media files, /system/media.  It
> should be a simple manifest change to whack those, and that will save 6.2MB.

I'll take care of that, it'll give us some much needed breathing room.

Comment 17

[Gabriele Svelto [:gsvelto]]

Todays releng build is smaller than yesterday but still doesn't fit. I'll make this bug block on 825142 and proceed to fix that one.

Comment 18

[Gabriele Svelto [:gsvelto]]

The Otoro releng build is flashable again though this is due to the default logo being smaller rather than the fix I've written for bug 825142. I've noticed that the releng build is trailing quite a bit behind our sources hence my fix hasn't been picked up yet. I'll close this bug and follow up on that to make sure we have more free space available in the future.