Remove unused stuff from mozilla manifests

RESOLVED FIXED

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: gsvelto)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

We have 12MB of wasted space in

  <project path="external/icu4c" name="platform/external/icu4c" />
  <project path="system/media" name="platform/system/media" />

I /think/ that just removing the manifest entries should fix that wagon.

Gabriele or John, want to grab?
(Assignee)

Comment 1

5 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> Gabriele or John, want to grab?

Got it :-)
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Tough luck, this seems more complicated than I had anticipated and we may not be able to remove icu4c at all. The first obstacle I encountered was that sqlite had a dependency on it. After getting rid of it too I hit a snag when trying to build the base system. Apparently the libmedia library is deeply ingrained in the core frameworks; a bunch of stuff from frameworks/base links to it and in particular libcameraservice. Since we actively use libcameraservice in Gonk I don't think we can get rid of that particular dependency. Now libmedia also depends on icu4c so I don't how we'd be able to get rid of icu4c easily (if at all).
(Assignee)

Updated

5 years ago
Blocks: 821703
(Assignee)

Comment 3

5 years ago
Created attachment 704033 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/14

Pointer to Github pull-request
(Assignee)

Comment 4

5 years ago
Comment on attachment 704033 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/14

The Android ringtones are part of the platform/frameworks/base project so they cannot be removed from the manifest, however we can prevent them from being packaged by removing the makefile step which includes them. This shaves ~6MiB from the build image and will make the Otoro releng builds flashable again.
Attachment #704033 - Flags: review?(mwu)
(Assignee)

Updated

5 years ago
Attachment #704033 - Flags: review?(mwu)
(Assignee)

Comment 5

5 years ago
Created attachment 705411 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/15

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #705411 - Flags: review?(mwu)
(Assignee)

Updated

5 years ago
Attachment #704033 - Attachment is obsolete: true

Updated

5 years ago
Attachment #705411 - Flags: review?(mwu) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 706695 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/45

Pointer to Github pull-request
(Assignee)

Comment 7

5 years ago
Created attachment 706696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/46

Pointer to Github pull-request
(Assignee)

Comment 8

5 years ago
Comment on attachment 706696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/46

This removes the apache-http, jhead and libphonenumber packages from all manifests. After much wrangling with dependencies and a discussion with :mwu we came to the conclusion that removing icu4c is almost impossible due to its dependencies with core libraries such as libmedia.
Attachment #706696 - Flags: review?(mwu)

Updated

5 years ago
Attachment #706696 - Flags: review?(mwu) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.