825142 - Remove unused stuff from mozilla manifests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We have 12MB of wasted space in

  <project path="external/icu4c" name="platform/external/icu4c" />
  <project path="system/media" name="platform/system/media" />

I /think/ that just removing the manifest entries should fix that wagon.

Gabriele or John, want to grab?

Comment 1

[Gabriele Svelto [:gsvelto]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> Gabriele or John, want to grab?

Got it :-)

Comment 2

[Gabriele Svelto [:gsvelto]]

Tough luck, this seems more complicated than I had anticipated and we may not be able to remove icu4c at all. The first obstacle I encountered was that sqlite had a dependency on it. After getting rid of it too I hit a snag when trying to build the base system. Apparently the libmedia library is deeply ingrained in the core frameworks; a bunch of stuff from frameworks/base links to it and in particular libcameraservice. Since we actively use libcameraservice in Gonk I don't think we can get rid of that particular dependency. Now libmedia also depends on icu4c so I don't how we'd be able to get rid of icu4c easily (if at all).

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/14

Pointer to Github pull-request

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 704033 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/14

The Android ringtones are part of the platform/frameworks/base project so they cannot be removed from the manifest, however we can prevent them from being packaged by removing the makefile step which includes them. This shaves ~6MiB from the build image and will make the Otoro releng builds flashable again.

Comment 5

[Gabriele Svelto [:gsvelto]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/platform_build/pull/15

Pointer to Github pull-request

Comment 6

[Gabriele Svelto [:gsvelto]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/45

Pointer to Github pull-request

Comment 7

[Gabriele Svelto [:gsvelto]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/46

Pointer to Github pull-request

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 706696 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/46

This removes the apache-http, jhead and libphonenumber packages from all manifests. After much wrangling with dependencies and a discussion with :mwu we came to the conclusion that removing icu4c is almost impossible due to its dependencies with core libraries such as libmedia.