822110 - filter.png, noise.png and showall.png in browser/devtools/profiler/cleopatra/images are empty

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Rob Campbell [:rc] (:robcee)]

Empty files landed in profiler/cleopatra. We should remove them if unused.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Updated Cleo light and removed unused image files.

Comment 2

[Alfred Kayser]

noise.png is also empty, and referred to in ui.css.
It should be removed, as well as the corr. part in the background-image statement, as it has not effect at all being empty).

Furthermore the -webkit- and -moz- lines should be removed from the cleopatra/*.css files.

Comment 3

[Anton Kovalyov (:anton)]

If you look at the attached patch you'll see that noise.png is not empty anymore. I'll remove prefixed CSS properties.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 693132 [details] [diff] [review]
Updated Cleo light and removed unused image files.

+@-webkit-keyframes darken {
+  from {

ugh. ok.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 693132 [details] [diff] [review]
Updated Cleo light and removed unused image files.

should also add a non-prefixed version of the @keyframes rules for fx 16+.

Comment 6

[Rob Campbell [:rc] (:robcee)]

can we ditch the -webkit and -moz prefixes entirely for this? Since cleo-light exists solely for inclusion in the browser, there's not much reason to keep them.

Comment 7

[Benoit Girard (:BenWa)]

Ideally cleo-light would use the same JS/CSS files as the normal cleopatra except for having a flag set. However the extra prefixes causes a lot of error console noise :(. Note that this 'update' doesn't really pull in the newer changes from cleopatra. One notable change is being able to click on the histogram to select a sample.

Comment 8

[Anton Kovalyov (:anton)]

Attachment: Removed unused image files, all of -webkit- and most of -moz- prefixes

Some -moz- properties are still there because caniuse.com shows that they are still prefixed in all version of Firefox.

Comment 9

[Rob Campbell [:rc] (:robcee)]

we should submit these changes as a pull request to the cleo-light branch in github.

Comment 10

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/14d68c173f81

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/14d68c173f81