filter.png, noise.png and showall.png in browser/devtools/profiler/cleopatra/images are empty

RESOLVED FIXED in Firefox 20

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: rcampbell, Assigned: anton)

Tracking

unspecified
Firefox 20
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [profiler])

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

7 years ago
Empty files landed in profiler/cleopatra. We should remove them if unused.
Reporter

Updated

7 years ago
Whiteboard: [profiler]
Assignee

Comment 1

7 years ago
Assignee: nobody → anton
Status: NEW → ASSIGNED
Attachment #693132 - Flags: review?(rcampbell)
Attachment #693132 - Flags: review?(bgirard)

Updated

7 years ago
Depends on: 795268

Comment 2

7 years ago
noise.png is also empty, and referred to in ui.css.
It should be removed, as well as the corr. part in the background-image statement, as it has not effect at all being empty).

Furthermore the -webkit- and -moz- lines should be removed from the cleopatra/*.css files.
Assignee

Comment 3

7 years ago
If you look at the attached patch you'll see that noise.png is not empty anymore. I'll remove prefixed CSS properties.
Reporter

Comment 4

7 years ago
Comment on attachment 693132 [details] [diff] [review]
Updated Cleo light and removed unused image files.

+@-webkit-keyframes darken {
+  from {

ugh. ok.
Attachment #693132 - Flags: review?(rcampbell) → review+
Reporter

Comment 5

7 years ago
Comment on attachment 693132 [details] [diff] [review]
Updated Cleo light and removed unused image files.

should also add a non-prefixed version of the @keyframes rules for fx 16+.
Reporter

Comment 6

7 years ago
can we ditch the -webkit and -moz prefixes entirely for this? Since cleo-light exists solely for inclusion in the browser, there's not much reason to keep them.
Reporter

Updated

7 years ago
Component: Developer Tools → Developer Tools: Profiler
OS: Mac OS X → All
Hardware: x86 → All
Attachment #693132 - Flags: review?(bgirard) → review+
Ideally cleo-light would use the same JS/CSS files as the normal cleopatra except for having a flag set. However the extra prefixes causes a lot of error console noise :(. Note that this 'update' doesn't really pull in the newer changes from cleopatra. One notable change is being able to click on the histogram to select a sample.
Assignee

Comment 8

7 years ago
Some -moz- properties are still there because caniuse.com shows that they are still prefixed in all version of Firefox.
Attachment #693132 - Attachment is obsolete: true
Attachment #697279 - Flags: review?(rcampbell)
Attachment #697279 - Flags: review?(bgirard)
Reporter

Updated

7 years ago
Attachment #697279 - Flags: review?(rcampbell) → review+
Reporter

Comment 9

7 years ago
we should submit these changes as a pull request to the cleo-light branch in github.
Attachment #697279 - Flags: review?(bgirard) → review+
Assignee

Updated

7 years ago
Whiteboard: [profiler] → [profiler][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/14d68c173f81
Whiteboard: [profiler][land-in-fx-team] → [profiler][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/14d68c173f81
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [profiler][fixed-in-fx-team] → [profiler]
Target Milestone: --- → Firefox 20

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.