822115 - nglayout.debug.widget_update_flashing pref cache is not thread safe

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Oleg Romashin (:romaxa)]

Assertion failure: _mOwningThread.GetThread() == PR_GetCurrentThread() (ValueObserver not thread-safe), at modules/libpref/src/Preferences.cpp:131

I have browser with OMTC enabled and BasicLayerManager::FlashWidgetUpdateArea first time called from Compositor Thread (create observer for nglayout.debug.widget_update_flashing)

and when gecko is shutting down, it removes all observers from GeckoThread. which cause assertion above.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: move nglayout.debug.widget_update_flashing to gfx::Init

Move pref observer initialization to gfxPlatform::Init which is guaranteed to be called in Gecko thread.

Comment 2

[Oleg Romashin (:romaxa)]

https://tbpl.mozilla.org/?tree=Try&rev=c2d12b6b36f8

Comment 3

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3722e35a871

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c3722e35a871