Closed
Bug 822289
Opened 12 years ago
Closed 12 years ago
Remove NS_IMPL_CYCLE_COLLECTION*_CLASS macros
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: mccr8, Assigned: tbsaunde)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
|
214.85 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Thanks to bug 819215, these don't do anything any more:
NS_IMPL_CYCLE_COLLECTION_NATIVE_CLASS
NS_IMPL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS
NS_IMPL_CYCLE_COLLECTION_LEGACY_NATIVE_CLASS
NS_IMPL_CYCLE_COLLECTION_CLASS
After this lands, we'll want to make a post to dev.platform mentioning the change, and update the wiki docs.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #703030 -
Flags: review?
|
|
Assignee | |
Comment 2•12 years ago
|
||
oops forgot to squash the commits with the other macros
Attachment #703030 -
Attachment is obsolete: true
Attachment #703030 -
Flags: review?
Attachment #703039 -
Flags: review?(continuation)
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 703039 [details] [diff] [review]
bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS
Review of attachment 703039 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for fixing this!
::: dom/src/geolocation/nsGeolocation.cpp
@@ -1110,5 @@
> NS_INTERFACE_MAP_END
>
> NS_IMPL_CYCLE_COLLECTING_ADDREF(nsGeolocation)
> NS_IMPL_CYCLE_COLLECTING_RELEASE(nsGeolocation)
> -NS_IMPL_CYCLE_COLLECTION_CLASS(nsGeolocation)
Leave the blank line here.
::: editor/libeditor/base/EditAggregateTxn.cpp
@@ -14,5 @@
> EditAggregateTxn::EditAggregateTxn()
> : EditTxn()
> {
> }
> -NS_IMPL_CYCLE_COLLECTION_CLASS(EditAggregateTxn)
Leave the blank line here.
Attachment #703039 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Comment on attachment 703039 [details] [diff] [review]
bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS
Review of attachment 703039 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
|
||
Comment 6•12 years ago
|
||
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•