822447 - Remove Character Encoding menu entries that are not in the Encoding Standard - port bug 805374

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[:aceman]

The removal of items in Core causes breakage in Thunderbird:

Error: undefined entity
Source file: chrome://messenger/content/mailWindowOverlay.xul
Line: 1665, Column: 21
Source code:
                    <menu label="&charsetMenuUnicode.label;"

And the whole TB UI is broken (empty).
I'll try to fix that.

+++ This bug was initially created as a clone of Bug #805374 +++

We are in the process of implementing http://encoding.spec.whatwg.org/ . The process involves removing support for legacy character decoders that aren’t really necessary for supporting existing Web content.

The removal of unnecessary items from the Character Encoding menu can happen in advance to removing the decoders for those encodings.

Expected results:
Expected the Character Encoding menu not to have entries that are not listed in http://encoding.spec.whatwg.org/

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Masatoshi Kimura [:emk]]

LGTM

Comment 3

[:aceman]

Is this all we need to do in Thunderbird? Just remove the menuitem?

Comment 4

[Masatoshi Kimura [:emk]]

Note that my patch haven't removed ISO-2022-JP at the moment. (And I'm not going to do it in near future.) The current patch have removed only UTF-16, UTF-16BE, and UTF-16LE.
So I believe it's sufficient to remove the "Unicode" menuitem for now.

Comment 5

[:aceman]

OK, thanks. I asked if we also need to remove some backend code from TB. But maybe everything was already done in toolkit part of the patch in bug 805374.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 693095 [details] [diff] [review]
patch

Looks good, thanks for doing the patch.

Comment 7

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/b1d043bedf62

Comment 8

[Mark Banner (:standard8)]

Ooh, probably want to leave open until bug 805374 is closed.

Comment 9

[Masatoshi Kimura [:emk]]

No longer a blocker.

Comment 10

[:aceman]

Does anybody have an idea if this is still needed to be open? We landed the patch here in TB20, while the core bug seems to have been closed at 28. Today I do not see any problem in TB. Do we have to wait for anything yet? The whiteboard comment seems to indicate we can close this. Maybe the Core bug did not remove any more charsets so we do not have to do anything more.

Comment 11

[Wayne Mery (:wsmwk)]

See comment 10

Comment 12

[Magnus Melin [:mkmelin]]

Nothing more to do here.