822450 - Create a dom pref to allow marionette events to trigger navigator.id.request

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Currently, marionette test events do not appear as native events to the DOM, which prevents us from testing code that checks whether it is handling user input (see Bug 821740).

nsDOMIdentity's navigator.id.requet() method checks that it is handling user input.  In order for native identity and marketplace testing to proceed on b2g, we need a workaround.

I suggest we create a pref like dom.identity.syntheticEventsOk that we can set when testing.

When Bug 821740 is resolved, we will be able to remove this pref.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: check for syntheticEventsOk pref

The pref can be set from a marionette test as follows:

self.marionette.execute_script(
    """SpecialPowers.setBoolPref("dom.identity.syntheticEventsOk", true);""")

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: check for syntheticEventsOk pref

Forgot you need to check for existence of user pref before querying its value

Comment 3

[Ben Adida [:benadida]]

Comment on attachment 693185 [details]
check for syntheticEventsOk pref

wish Marionette could do the truly correct thing, but barring that, this looks good.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: check for syntheticEventsOk pref

r=benadida

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Ryan, hg doesn't like the date on my patch :(

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: argh - date string in header was invalid

Fixed date string in header

(how do you do timezones in header dates?)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1114846b3791

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1114846b3791

Comment 9

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 693609 [details] [diff] [review]
argh - date string in header was invalid

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 821740
User impact if declined: Automated testing won't be possible for identity and marketplace
Testing completed: marionette test suite
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none

Comment 10

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I've requested that this land in b2g18 so we can perform automated tests of identity and marketplace (whose flow depends on identity).

Comment 11

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

... this will not be necessary if QA works with latest builds we make here; only if they want to do automated testing on what the OEMs get with v1.

Comment 12

[Jonathan Griffin (:jgriffin)]

Requesting tef+, see comment #9; without this we won't be able to run identify tests on mozilla-b2g18.

Comment 13

[Jason Smith [:jsmith]]

(In reply to Jonathan Griffin (:jgriffin) from comment #12)
> Requesting tef+, see comment #9; without this we won't be able to run
> identify tests on mozilla-b2g18.

That would be a case to track, not block actually. This wouldn't stop ship of the phone.

Comment 14

[Andrew Overholt [:overholt]]

It seems that the main reason to take this for B2G v1.0.0 would be to prevent regressions but since we're taking *very* few patches there, let's not take this now.  I'm leaving the nom for 1.0.x triage.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 693609 [details] [diff] [review]
argh - date string in header was invalid

Please go ahead with uplift to the tip of mozilla-b2g18 branch for v1.0.1

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/185c947cda31