822572 - Add a Clear Downloads button to the Library view

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Marco Bonardo [:mak]]

I think this is still missing, we should add it, somewhere in the window.

Comment 1

[Marco Bonardo [:mak]]

2 possibilities:
1. get rid of the details pane (it's pointless) and just put it there
2. put it in the Library toolbar just when the downloads view is shown

Comment 2

[Asaf Romano (gone)]

I've got a patch for this.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mano from comment #2)
> I've got a patch for this.

Can you please post your patch?

Comment 4

[Marco Bonardo [:mak]]

here we will need a RemoveVisitsByTransition API, so this should be fixed before the Aurora merge.

In comment 1 I explained 2 possibilities, though we may also:
3. Just add "Clear List" to the context menu

Comment 5

[u428464]

A button would be a lot better. There is more than enough room for it.

Comment 6

[u428464]

It's also important to note than most of library's contextual action/buttons are useless in the download view (especially "view" and "import and backup")

Comment 7

[Marco Bonardo [:mak]]

(In reply to Guillaume C. [:ge3k0s] from comment #6)
> It's also important to note than most of library's contextual action/buttons
> are useless in the download view (especially "view" and "import and backup")

Ideally we may use the options object I've added to the views to specify sort of a currentset, and then show/hide buttons on the toolbar dinamically based on that list. Should not be too hard to replace currently useless buttons with the Clear All Downloads button.

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 9

[Asaf Romano (gone)]

Comment on attachment 698283 [details] [diff] [review]
patch v1.0

r=mano. minor nits discussed over irc.

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Note this may still need some theming work (add an icon, fix padding), though I'll file a separate bug for that, what matters here is adding the missing strings and functionality.

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1be4b28a143d

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1be4b28a143d