Closed Bug 822572 Opened 7 years ago Closed 7 years ago

Add a Clear Downloads button to the Library view

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file, 1 obsolete file)

I think this is still missing, we should add it, somewhere in the window.
2 possibilities:
1. get rid of the details pane (it's pointless) and just put it there
2. put it in the Library toolbar just when the downloads view is shown
Depends on: 822848
Component: Downloads Panel → Bookmarks & History
Priority: -- → P1
I've got a patch for this.
Assignee: nobody → mano
(In reply to Mano from comment #2)
> I've got a patch for this.

Can you please post your patch?
here we will need a RemoveVisitsByTransition API, so this should be fixed before the Aurora merge.

In comment 1 I explained 2 possibilities, though we may also:
3. Just add "Clear List" to the context menu
A button would be a lot better. There is more than enough room for it.
It's also important to note than most of library's contextual action/buttons are useless in the download view (especially "view" and "import and backup")
Depends on: 825849
(In reply to Guillaume C. [:ge3k0s] from comment #6)
> It's also important to note than most of library's contextual action/buttons
> are useless in the download view (especially "view" and "import and backup")

Ideally we may use the options object I've added to the views to specify sort of a currentset, and then show/hide buttons on the toolbar dinamically based on that list. Should not be too hard to replace currently useless buttons with the Clear All Downloads button.
Assignee: mano → mak77
Status: NEW → ASSIGNED
Summary: Add a Clear All Downloads option to the Library view → Add a Clear Downloads button to the Library view
Attached patch patch v1.0 (obsolete) — Splinter Review
Attachment #698283 - Flags: review?(mano)
Comment on attachment 698283 [details] [diff] [review]
patch v1.0

r=mano. minor nits discussed over irc.
Attachment #698283 - Flags: review?(mano) → review+
Attached patch patch v1.1Splinter Review
Note this may still need some theming work (add an icon, fix padding), though I'll file a separate bug for that, what matters here is adding the missing strings and functionality.
Attachment #698283 - Attachment is obsolete: true
Blocks: 827015
https://hg.mozilla.org/mozilla-central/rev/1be4b28a143d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.