Closed Bug 822848 Opened 8 years ago Closed 8 years ago

hide the detailsPane for the new downloads view

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

we don't need a details pane, it should be collapsed so we maximize the content area.
Blocks: 822572
Priority: -- → P2
when we open the Library view from Show all downloads, looks like the details pane is not properly initialized, so it has the wrong size (it's too tall and covers most of the view).
So this becomes a bit more important.
Priority: P2 → P1
Attached patch patch v1.0Splinter Review
Since I'd like to enable the new view by default in Nightly, I want to address this.
This patch is a first possibility, when registering a custom view allow to pass an optional options object. The only supported option for now is showDetailsPane.

While working on this I found a possible typo in the view selectedNodes getter.

I was thinking we may also use these options to customize the Library toolbar (like passing a sort of currentSet) to hide Views and add the Clear all downloads button. But I'm not sure if you had a different idea in mind.
Attachment #696147 - Flags: review?(mano)
Backed out for failing browser_library_downloads.js: https://hg.mozilla.org/integration/mozilla-inbound/rev/311689a4858f
relanded, not culprit for the failure
https://hg.mozilla.org/integration/mozilla-inbound/rev/9119f282e0c0
https://hg.mozilla.org/mozilla-central/rev/9119f282e0c0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.