822848 - hide the detailsPane for the new downloads view

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Marco Bonardo [:mak]]

we don't need a details pane, it should be collapsed so we maximize the content area.

Comment 1

[Marco Bonardo [:mak]]

when we open the Library view from Show all downloads, looks like the details pane is not properly initialized, so it has the wrong size (it's too tall and covers most of the view).
So this becomes a bit more important.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Since I'd like to enable the new view by default in Nightly, I want to address this.
This patch is a first possibility, when registering a custom view allow to pass an optional options object. The only supported option for now is showDetailsPane.

While working on this I found a possible typo in the view selectedNodes getter.

I was thinking we may also use these options to customize the Library toolbar (like passing a sort of currentSet) to hide Views and add the Clear all downloads button. But I'm not sure if you had a different idea in mind.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 696147 [details] [diff] [review]
patch v1.0

I like it.

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cce44d592e67

Comment 5

[Josh Matthews [:jdm]]

Backed out for failing browser_library_downloads.js: https://hg.mozilla.org/integration/mozilla-inbound/rev/311689a4858f

Comment 6

[Marco Bonardo [:mak]]

relanded, not culprit for the failure
https://hg.mozilla.org/integration/mozilla-inbound/rev/9119f282e0c0

Comment 7

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/9119f282e0c0