hide the detailsPane for the new downloads view

RESOLVED FIXED in Firefox 20

Status

()

Firefox
Bookmarks & History
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

unspecified
Firefox 20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
we don't need a details pane, it should be collapsed so we maximize the content area.
(Assignee)

Updated

5 years ago
Blocks: 822572
(Assignee)

Updated

5 years ago
Priority: -- → P2
Assignee: nobody → mano
(Assignee)

Comment 1

5 years ago
when we open the Library view from Show all downloads, looks like the details pane is not properly initialized, so it has the wrong size (it's too tall and covers most of the view).
So this becomes a bit more important.
Priority: P2 → P1
(Assignee)

Comment 2

5 years ago
Created attachment 696147 [details] [diff] [review]
patch v1.0

Since I'd like to enable the new view by default in Nightly, I want to address this.
This patch is a first possibility, when registering a custom view allow to pass an optional options object. The only supported option for now is showDetailsPane.

While working on this I found a possible typo in the view selectedNodes getter.

I was thinking we may also use these options to customize the Library toolbar (like passing a sort of currentSet) to hide Views and add the Clear all downloads button. But I'm not sure if you had a different idea in mind.
Attachment #696147 - Flags: review?(mano)
Comment on attachment 696147 [details] [diff] [review]
patch v1.0

I like it.
Attachment #696147 - Flags: review?(mano) → review+
Assignee: mano → mak77
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cce44d592e67
Target Milestone: --- → Firefox 20

Comment 5

5 years ago
Backed out for failing browser_library_downloads.js: https://hg.mozilla.org/integration/mozilla-inbound/rev/311689a4858f
(Assignee)

Comment 6

5 years ago
relanded, not culprit for the failure
https://hg.mozilla.org/integration/mozilla-inbound/rev/9119f282e0c0
https://hg.mozilla.org/mozilla-central/rev/9119f282e0c0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.