Closed Bug 822848 Opened 10 years ago Closed 10 years ago

hide the detailsPane for the new downloads view


(Firefox :: Bookmarks & History, defect, P1)




Firefox 20


(Reporter: mak, Assigned: mak)




(1 file)

we don't need a details pane, it should be collapsed so we maximize the content area.
Blocks: 822572
Priority: -- → P2
Assignee: nobody → mano
when we open the Library view from Show all downloads, looks like the details pane is not properly initialized, so it has the wrong size (it's too tall and covers most of the view).
So this becomes a bit more important.
Priority: P2 → P1
Attached patch patch v1.0Splinter Review
Since I'd like to enable the new view by default in Nightly, I want to address this.
This patch is a first possibility, when registering a custom view allow to pass an optional options object. The only supported option for now is showDetailsPane.

While working on this I found a possible typo in the view selectedNodes getter.

I was thinking we may also use these options to customize the Library toolbar (like passing a sort of currentSet) to hide Views and add the Clear all downloads button. But I'm not sure if you had a different idea in mind.
Attachment #696147 - Flags: review?(mano)
Comment on attachment 696147 [details] [diff] [review]
patch v1.0

I like it.
Attachment #696147 - Flags: review?(mano) → review+
Assignee: mano → mak77
Backed out for failing browser_library_downloads.js:
relanded, not culprit for the failure
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.