822705 - the +1 button on self serve should increase the job priority not decrease it

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I'm 99% sure the +1 button decreases it, based on the priorities here: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/master_common.py#L22

Comment 1

[Phil Ringnalda (:philor)]

Whether it increases or decreases it, and whether increasing it means giving it a larger number so that it will be done more slowly than it otherwise would have or the reverse, they are unusable as-is, and whenever anyone asks me, I advise staying away from them unless you don't care whether your job is done first or dead last.

Could we have tooltips on the buttons which do not mention either the word "priority" or the words "increase" and "decrease," something along the lines of "Make this job happen sooner than it otherwise would" and "Make this job happen later than it otherwise would"?

Comment 2

[Phil Ringnalda (:philor)]

Experimentally, the +1 button causes a job to happen sooner than it otherwise would.

Comment 3

[Chris AtLee [:catlee]]

I'm pretty sure +1 makes it happen sooner as well. So we need to label it as such on self-serve?

http://hg.mozilla.org/build/buildapi/file/3200f4dd3f34/buildapi/templates/self-serve/branch.mako#l122

Comment 4

[Phil Ringnalda (:philor)]

Yeah. If we don't want to add a title param to priority_form, bz's suggestion for "how can you express "[Cut to the front of the line]" and "[No hurry, 2am will do]" in six or eight characters each?" of "mememe and allgood" actually isn't half bad.

Comment 5

[Chris AtLee [:catlee]]

"nownownow!" and "mañana"?

Comment 6

[Phil Ringnalda (:philor)]

Dunno - am I right that increasing the priority of your Win7 browser-chrome test on a try push means "make this the very next Win7 test which runs on try, unless someone who pushed before me was smart enough to increase the priority of their tests, too" and if so, will people realize that the "nownownow!" button means "shove ahead of everyone else who is dumb enough to wait in line, because nothing matters but me?"

Comment 7

[Chris AtLee [:catlee]]

Fixing this in https://bugzilla.mozilla.org/show_bug.cgi?id=630633#c3 by labeling the buttons "run me sooner" and "run me later"