8228 - BUILD: no raptor in dll names

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Brendan Eich [:brendan]]

No more raptor in DLL names, right?  raptorbase down, four or so to go.

/be

Comment 1

[Suresh Duddi (gone)]

We should add necko to the dll name list.

Comment 2

[Suresh Duddi (gone)]

Dan veditz removed a lot of these on windows with his exercist of converting
dlls to 8.3

Suggestions ? necko->net ; raptor->layout

./components/libnecko.so
./components/libnecko_about.so
./components/libnecko_data.so
./components/libnecko_file.so
./components/libnecko_resource.so
./components/libnecko_ftp.so
./components/libnecko_http.so
./components/libnecko_keyword.so
./components/libraptorhtmlpars.so
./components/libraptorview.so
./components/libraptorhtml.so
./libraptorplugin.so
./libraptorgfx.so
./libraptorwebwidget.so

./res/samples/raptor.jpg
./components/necko_base.xpt
./components/necko_dns.xpt
./components/necko_socket.xpt
./components/necko_about.xpt
./components/necko_data.xpt
./components/necko_file.xpt
./components/necko_ftp.xpt
./components/necko_http.xpt
./components/necko_stream_converter.xpt

Comment 3

[Chris Yeh]

you really should be doing this _before_ you go to beta, not after. why M16?

Comment 4

[Daniel Veditz [:dveditz]]

The only reason we changed the necko names was because of the win 8.3
limitation. In the .dlls we used the abbreviation "nk", but we did not change
the name of any of the .xpt files.  The .xpt files should be the same
cross-platform so if you change them coordinate with mac and windows.

Comment 5

[Warren Harris]

We didn't change the necko dll names because we intend to consolidate them into
2 dlls. (Bug 17031). Unfortunately Dan needed changes sooner.

Maybe somebody on the raptor team should own this task.

Comment 6

[Suresh Duddi (gone)]

Rick you want to own this ?

Comment 7

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 8

[rickg]

This bug has been marked "future" because the original netscape engineer 
working on this is over-burdened. If you feel this is an error, that you or 
another known resource will be working on this bug,or if it blocks your work 
in some way -- please attach your concern to the bug for reconsideration. 

Comment 9

[cls]

IMO, if we are going to rename libs, we should've done it a year ago when this
bug was first opened.  Nominating for nsbeta2 status as we're talking about an
external end-user visible change.  I'll take the bug if necessary as I think all
that needs to be done are build changes and possible renaming of some files.

Comment 10

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.

Comment 11

[Brendan Eich [:brendan]]

Rick, is it ok if cls takes this bug?  He's motivated and capable.

/be

Comment 12

[rickg]

Happy to have the help, thanks for the assist.

Comment 13

[Brendan Eich [:brendan]]

Reassigning.

/be

Comment 14

[Brendan Eich [:brendan]]

*** Bug 3700 has been marked as a duplicate of this bug. ***

Comment 15

[cls]

Here are the current renaming suggestions:

MODULE=raptor		-> MODULE=layout
MODULE=raptor		-> MODULE=view (view/*/Makefile.in)
MODULE=raptor		-> MODULE=webshell (webshell/*/Makefile.in)
MODULE=raptor		-> MODULE=widget (widget/*/Makefile.in)
MODULE=raptor		-> MODULE=appshell (xpfe/appshell/*/Makefile.in)

libraptorgfx.so		-> libmozgfx.so
libraptorview.so	-> libmozview.so
libraptorplugin.so	-> libngplugin.so
libraptorhtmlpars.so	-> libhtmlpars.so
libraptorwebwidget.so	-> libwebshell.so
libraptorhtml.so	-> libnglayout.so

libraptorlayout_s.a	-> libnglbase_s.a
libraptorevents_s.a	-> libnglevents_s.a
libraptorhtmlbase_s.a	-> libnglhtmlbase_s.a
libnglhtmlcon_s.a	-> libnglhtmlcon_s.a
libraptorhtmldoc_s.a	-> libnglhtmldoc_s.a
libraptorhtmlforms_s.a	-> libnglhtmlforms_s.a
libraptorhtmlstyle_s.a	-> libnglhtmlstyle_s.a
libraptorhtmltable_s.a	-> libnglhtmltable_s.a
libraptorxmlcontent_s.a	-> libnglxmlcon_s.a
libraptorxmldoc_s.a	-> libnglxmldoc_s.a
libraptorxulcontent_s.a	-> libnglxulcon_s.a
libraptorxulbase_s.a	-> libnglxulbase_s.a
libraptorxbl_s.a	-> libnglxbl_s.a
libraptormathmlcontent_s.a -> libnglmathmlcon_s.a
libraptormathmlbase_s.a	-> libnglmathmlbase_s.a
libraptorsvgcontent_s.a	-> libnglsvgcon_s.a
libraptorsvgbase_s.a	-> libnglsvgbase_s.a
libraptorxsldoc_s.a	-> libnglxsldoc_s.a

libraptorbasewidget_s.a	-> libxpwidgets_s.a

Comment 16

[Warren Harris]

I'd prefer to see the prefix 'gk' rather than 'ngl'. We're using 'nk' for necko. 
"Next generation" will wear thin.

Comment 17

[cls]

Attachment: patch to remove raptor from dlls for unix builds

Comment 18

[cls]

Patch has been tested on the commercial build and checked in.
Here are the last minute changes:
updated packages-unix
raptorgfx 	-> gkgfx
raptorplugin	-> gkplugin
raptorview	-> gkview

These are more inline with the names used by the win32 build.  Best I can tell,
someone (I think it was dveditz) already made the changes to win32.  raptor is
still used in a number of places for the intermediate static libs but not for
the dynamic ones.  There's also a bunch of references to -I$(PUBLIC)/raptor but
I was sure we stopped using that awhile ago. 

Marking fixed.