Closed Bug 823009 Opened 8 years ago Closed 8 years ago

Attachment Reminders not triggering due to removal of nsIMutationObserverCallback (Permanent Orange | TEST-UNEXPECTED-FAIL | test-attachment-reminder.js)

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 20.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 790978 removed nsIMutationObserverCallback but it looks like we don't actually need it.
Attached patch The fixSplinter Review
This should fix the mozmill bustage and some other related bustage on the popup menu for showing all the tabs.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #693850 - Flags: review?(mconley)
Comment on attachment 693850 [details] [diff] [review]
The fix

Review of attachment 693850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great - just one nit. Thanks Mark!

::: mail/base/content/tabmail.xml
@@ +2370,5 @@
>                    .getInterface(Components.interfaces.nsIXULWindow);
>          }
>          catch(ex) { }
> +
> +        var tabmailalltabspopup = this;

use let as opposed to var
Attachment #693850 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/992b9cefcb15
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.