823009 - Attachment Reminders not triggering due to removal of nsIMutationObserverCallback (Permanent Orange | TEST-UNEXPECTED-FAIL | test-attachment-reminder.js)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

Bug 790978 removed nsIMutationObserverCallback but it looks like we don't actually need it.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This should fix the mozmill bustage and some other related bustage on the popup menu for showing all the tabs.

Comment 2

[Legacy TBPL/Treeherder Robot]

Standard8
https://tbpl.mozilla.org/php/getParsedLog.php?id=18090857&tree=Thunderbird-Trunk
TB Rev3 Fedora 12 comm-central opt test mozmill on 2012-12-19 04:19:37
slave: talos-r3-fed-027

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_dismissal
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_aggressive_pref
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_no_send_now_sends
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 693850 [details] [diff] [review]
The fix

Review of attachment 693850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great - just one nit. Thanks Mark!

::: mail/base/content/tabmail.xml
@@ +2370,5 @@
>                    .getInterface(Components.interfaces.nsIXULWindow);
>          }
>          catch(ex) { }
> +
> +        var tabmailalltabspopup = this;

use let as opposed to var

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/992b9cefcb15