Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Attachment Reminders not triggering due to removal of nsIMutationObserverCallback (Permanent Orange | TEST-UNEXPECTED-FAIL | test-attachment-reminder.js)

RESOLVED FIXED in Thunderbird 20.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({intermittent-failure})

Trunk
Thunderbird 20.0
intermittent-failure

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 790978 removed nsIMutationObserverCallback but it looks like we don't actually need it.
Created attachment 693850 [details] [diff] [review]
The fix

This should fix the mozmill bustage and some other related bustage on the popup menu for showing all the tabs.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #693850 - Flags: review?(mconley)
Comment hidden (Treeherder Robot)
Comment on attachment 693850 [details] [diff] [review]
The fix

Review of attachment 693850 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great - just one nit. Thanks Mark!

::: mail/base/content/tabmail.xml
@@ +2370,5 @@
>                    .getInterface(Components.interfaces.nsIXULWindow);
>          }
>          catch(ex) { }
> +
> +        var tabmailalltabspopup = this;

use let as opposed to var
Attachment #693850 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/992b9cefcb15
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in before you can comment on or make changes to this bug.