Closed
Bug 823080
Opened 12 years ago
Closed 12 years ago
C4099 warning spam on MSVC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
|
20.40 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
It looks like it was caused by bug 817818.
Either revert the s/struct/class/; change or update also jspubtd.h.
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 694826 [details] [diff] [review]
Fix warning spam on MSVC
Review of attachment 694826 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jspubtd.h
@@ +190,5 @@
> typedef struct JSPropertyDescriptor JSPropertyDescriptor;
> typedef struct JSPropertyName JSPropertyName;
> typedef struct JSPropertySpec JSPropertySpec;
> typedef struct JSRuntime JSRuntime;
> +class JSScript;
Can you preserve the semblance of C compatibility by moving JSFunction and JSScript into the #ifdef __cplusplus block? And add a C-only struct declaration, as with the others in that block.
Attachment #694826 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•