823080 - C4099 warning spam on MSVC

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Masatoshi Kimura [:emk]]

It looks like it was caused by bug 817818.
Either revert the s/struct/class/; change or update also jspubtd.h.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Fix warning spam on MSVC

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 694826 [details] [diff] [review]
Fix warning spam on MSVC

Review of attachment 694826 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jspubtd.h
@@ +190,5 @@
>  typedef struct JSPropertyDescriptor         JSPropertyDescriptor;
>  typedef struct JSPropertyName               JSPropertyName;
>  typedef struct JSPropertySpec               JSPropertySpec;
>  typedef struct JSRuntime                    JSRuntime;
> +class JSScript;

Can you preserve the semblance of C compatibility by moving JSFunction and JSScript into the #ifdef __cplusplus block? And add a C-only struct declaration, as with the others in that block.

Comment 5

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/847d24f0a8da

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/847d24f0a8da