[Dialer] No response when answer/hang up/redial from bluetooth handsfree

VERIFIED FIXED in B2G C3 (12dec-1jan)

Status

P3
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: gyeh, Assigned: rudyl)

Tracking

unspecified
B2G C3 (12dec-1jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:+, b2g18+ fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Since the property name of system message is changed, we need to update Dialer app, too.

Topic: "bluetooth-dialer-command"
Original message: {"bluetooth-dialer-command":"ATA"}
New message: {"command":"ATA"}
Triage: BB-, tracking-b2g18+. decided not to support BT handsfree action button for v1
blocking-basecamp: ? → -
tracking-b2g18: --- → +
refer to bug 820655 for de-scope decision
I would like to renominate this as a bb+, because if this issue is not fixed, most HFP functions won't work. The user will be unable to answer a call, hang up, or redial.

The root cause of this bug are two. First, Gina found a typo of the topic of system messages sent from Gecko Bluetooth. About the same time, Gina had finished her work for bug 820103, which would send an "ATD" command to Dialer with a phone number supplied with remote Bluetooth headset. Both of these need some modification in Dialer. So Gina revised both, pushed, and filed bug 823416.

I believe the patch of the bug will be a fairly low-risk revision.
blocking-basecamp: - → ?
Chris could you confirm this is not for V1 ?
blocking-basecamp: ? → -
Flags: needinfo?(clee)
I spoke with clee about this.
While we will not support many of the HFP functions for v1, without this fix, basic functionality (like answering a call) will not work.  
Eric, is a patch ready for this?
Flags: needinfo?(clee) → needinfo?(echou)
(In reply to Peter Dolanjski from comment #5)
> I spoke with clee about this.
> While we will not support many of the HFP functions for v1, without this
> fix, basic functionality (like answering a call) will not work.  
> Eric, is a patch ready for this?

Yes, we've got a solution. Rudy will take over this.

Eric
Flags: needinfo?(echou)
(In reply to Peter Dolanjski from comment #5)
> I spoke with clee about this.
> While we will not support many of the HFP functions for v1, without this
> fix, basic functionality (like answering a call) will not work.  

Chris is right, we won't be able to answer a call/hang up a call/redial without fixing this.

Should I renominate as a bb+ to ensure this will be checked into b2g-18?
blocking-basecamp: - → ?
Assignee: nobody → rlu
Created attachment 695574 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

Pointer to Github pull-request
Attachment #695574 - Flags: review?(etienne)
Triage: agree with comment 5. BB+
blocking-basecamp: ? → +
Priority: -- → P3
Target Milestone: --- → B2G C3 (12dec-1jan)
Created attachment 695622 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/files

Pointer to Github pull-request
Comment on attachment 695574 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

Evelyn, please help review this patch.
Thanks.
Attachment #695574 - Flags: review?(etienne) → review?(ehung)

Comment 12

6 years ago
Comment on attachment 695574 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7182/commits

r=me, please update correct message from Gecko here, so the code will be synced with this issue.
Attachment #695574 - Flags: review?(ehung) → review+
Fixed with,
https://github.com/mozilla-b2g/gaia/commit/d49894d7465af21a5c24167e09c58edf56026b26

Evelyn, thank you for the review.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
QA Contact: wachen
Verified fix in pvt build 2013-1-3
Status: RESOLVED → VERIFIED
status-b2g18: --- → fixed
You need to log in before you can comment on or make changes to this bug.