820103 - bluetooth Hfp memory dialing and Hfp supplied number not supported

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Greg Grisco]

1. Switch ON BT from Settings>Bluetooth.
2. Pair to a Headset
3. Try memory Dialing from HF

Feature seems to not be supported.  Wanted to see if this was intentional or not.

Comment 1

[Greg Grisco]

I checked BluetoothHfpManager::ReceiveSocketData but didn't see any handling of "ATD".

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): bluetooth Hfp memory dialing and Hfp supplied number not supported

Comment 3

[Eric Chou [:ericchou] [:echou]]

(In reply to ggrisco from comment #0)
> 1. Switch ON BT from Settings>Bluetooth.
> 2. Pair to a Headset
> 3. Try memory Dialing from HF
> 
> Feature seems to not be supported.  Wanted to see if this was intentional or
> not.

No, not intentional, just missed it.

Please note:

* Dialer app won't support memory dialing by v1, so we'll respond with ERROR.
  (HFP spec 4.19 "Memory Dialing from the HF")

* In addition, we need support from Etienne, the owner of Dialer app, to modify
  Dialer so that an outgoing call can be established with the phone number supplied
  by HF after receiving system message sent from Bluetooth. Gina will file another 
  bug for this.

This should be bb+. Please let us know if you have any questions.

Eric

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 690755 [details] [diff] [review]
Patch 1(v1): bluetooth Hfp memory dialing and Hfp supplied number not supported

Review of attachment 690755 [details] [diff] [review]:
-----------------------------------------------------------------

ok, looks good, but this patch has modified the interface of system message between Bluetooth and Dialer, so please file another bug for Etienne and mark dependency properly.

Comment 5

[Chris Lee [:clee]]

The product team is looking into this and will follow-up with Eric shortly.

Comment 6

[Eric Chou [:ericchou] [:echou]]

Synced with product team. We'll fix this based on the principal mentioned in comment 3. The patch should work with Bug 820655 fixed.

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v2): bluetooth Hfp memory dialing and Hfp supplied number not supported

Some examples of ATD command with a specific number are "ATD+886212345678;\r", "ATD8158975;". Note that we only keep string "ATD" and the phone number in the system message of bluetooth-dialer-command.

Comment 8

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 692804 [details] [diff] [review]
Patch 1(v2): bluetooth Hfp memory dialing and Hfp supplied number not supported

Review of attachment 692804 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits addressed.

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +570,5 @@
> +  } else if (!strncmp(msg, "ATD>", 4)) {
> +    // Currently, we don't support memory dialing in Dialer app
> +    SendLine("ERROR");
> +  } else if (!strncmp(msg, "ATD", 3)) {
> +    nsCString message(msg), newMsg;

Nit: since message & newMsg are used locally, let's declare them as nsAutoCString instead of nsCString.

@@ +571,5 @@
> +    // Currently, we don't support memory dialing in Dialer app
> +    SendLine("ERROR");
> +  } else if (!strncmp(msg, "ATD", 3)) {
> +    nsCString message(msg), newMsg;
> +    int end = message.FindChar(';', 0);

Nit: using FindChar(';') should work, no need to pass the 2nd argument in if it's 0.

@@ +572,5 @@
> +    SendLine("ERROR");
> +  } else if (!strncmp(msg, "ATD", 3)) {
> +    nsCString message(msg), newMsg;
> +    int end = message.FindChar(';', 0);
> +    newMsg += nsDependentCSubstring(message, 0, end);

Needs error handling here if end == -1

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: bluetooth Hfp memory dialing and Hfp supplied number not supported, r=echou

try: 
https://tbpl.mozilla.org/?tree=Try&rev=0e8ff7903fd9
https://tbpl.mozilla.org/?tree=Try&rev=06257b6ca239

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff251b3e073f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff251b3e073f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/796e971014dc
https://hg.mozilla.org/releases/mozilla-b2g18/rev/1c29910bacf2