Closed Bug 823634 Opened 12 years ago Closed 12 years ago

Reason & message of the day strings should have leading and trailing whitespace removed

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: ewong)

References

Details

Attachments

(1 file)

A pretty common pattern is for sheriffs to copy and paste reasons using triple-click on history/wherever and paste, which leads to a trailing space. This then shows up in TBPL due to the appending of the period. We should trim trailing and leading whitespace from both the reason and the message of the day, before saving to the DB. Whilst we're at it, we could trim off the period (if present) at the end of the reason, so we don't get two appended, once TBPL combines reason and message of the day.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached file Pull request for patch
Attachment #732175 - Flags: review?(catlee)
Attachment #732175 - Flags: review?(catlee) → review+
Depends on: 867213
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
Product: Webtools → Tree Management
Product: Tree Management → Release Engineering
Component: Applications: TreeStatus → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: