867213 - Please push treestatus 85138c89b59e6cb3c0328301e9b26e5d17430038 to production

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Ed Morley [:emorley]]

Please can treestatus master head be pushed to production (https://github.com/mozilla/treestatus/commit/75f9a51d05b9936bc8c975cbfe951bbe3ac25fd4).

Also, I don't suppose you could tell me which revision is currently being used in production?

Many thanks :-)

Comment 1

[Chris Turra [:cturra]]

i have pushed master to stage for your testing. please give it a review and confirm you're happy with this going to production.

  https://treestatus.allizom.org/


you can always find the current revision in production at the following location:

  https://treestatus.mozilla.org/static/revision_info.txt

Comment 2

[Ed Morley [:emorley]]

catlee, I'm getting "Invalid BrowserID assertion" on the repoze.who.plugins.browserid.postback page. Any ideas? The who.ini overwritten perhaps?

(In reply to Chris Turra [:cturra] from comment #1)
> you can always find the current revision in production at the following
> location:
> 
>   https://treestatus.mozilla.org/static/revision_info.txt

Ah that's helpful, thank you :-)

Please hold off pushing to production until we can figure out the error above.

Comment 3

[Ed Morley [:emorley]]

Changelog:
https://github.com/mozilla/treestatus/compare/41fb79d69f1e362ba008fc32d48255fcbc36e8ff...master

Comment 4

[Chris Turra [:cturra]]

(In reply to Ed Morley [:edmorley UTC+1] from comment #2)
> catlee, I'm getting "Invalid BrowserID assertion" on the
> repoze.who.plugins.browserid.postback page. Any ideas? The who.ini
> overwritten perhaps?

looks like that was exactly the issue. maybe we should add who.ini to a .gitignore file in the repo?

Comment 5

[Ed Morley [:emorley]]

(In reply to Chris Turra [:cturra] from comment #4)
> looks like that was exactly the issue. maybe we should add who.ini to a
> .gitignore file in the repo?

Agreed, have filed bug 867238 for this. Will hold off pushing to production until we have that landed, to save having to do this all over again next time :-)

Comment 6

[Ed Morley [:emorley]]

Chris T, please may you push latest HEAD (6e4367bdc8450d16b8f42f4429f610424ad93cc1) to staging :-)

Comment 7

[Chris Turra [:cturra]]

i have pushed to stage again the who.ini file was removed and who.ini.example replaced it.

  rename treestatus.allizom.org/tree-status/{who.ini => who.ini.example} (89%)


i have recreated this file. so when we deploy this to prod, we will want to first take a copy of who.ini so it doesn't get removed ;) then place it back once the update is complete.

Comment 8

[Ed Morley [:emorley]]

Thank you - sorry for the hassle.

I'm unable to sign in on treestatus.allizom.org, I get "Invalid BrowserID assertion" still - I can only think that the recreated who.ini is missing something still?

Comment 9

[Chris Turra [:cturra]]

the who.ini file is indeed there and looks correctly configured to me. i just did an `apachectl graceful` on the node and tested a browserid login, which returned a "Sorry!  You do not have permission to login to this system." so auth looks to have worked correctly this time around - can you confirm you're seeing the same?

Comment 10

[Chris AtLee [:catlee]]

I can log in ok

Comment 11

[Chris Turra [:cturra]]

:edmorley - can i please get your ack before i push this to prod?

Comment 12

[Ed Morley [:emorley]]

Sorry for the delay - whilst logging in was working for me this morning (after restarting the browser and clearing cache), I spotted an issue with one of the things that was being pushed to prod.

I've landed a couple of fixes - please can you update staging to 403602618fcca6bbd9b62c8794dfd1b39360bf85.

Sorry for the back and forth on this! (Though least these were caught before being in production) :-)

Comment 13

[Ed Morley [:emorley]]

*Sigh* one more, sorry! (still getting used to git, missed off this hunk after testing locally)

Please may you update staging to 85138c89b59e6cb3c0328301e9b26e5d17430038

Comment 14

[Chris Turra [:cturra]]

commit 85138c89b59e6cb3c0328301e9b26e5d17430038 pushed to stage.

Comment 15

[Ed Morley [:emorley]]

This looks good to push to production now - thank you.

Please may you make a copy of who.ini from production, before pushing to prod, and then add the file back, per comment 7 (last time we'll have to do this dance, at least! :-)).

Comment 16

[Ed Morley [:emorley]]

Changes:
https://github.com/mozilla/treestatus/compare/41fb79d69f1e362ba008fc32d48255fcbc36e8ff...85138c89b59e6cb3c0328301e9b26e5d17430038#files_bucket

Comment 17

[Chris Turra [:cturra]]

push to prod complete! please give it a test and confirm i got everything right with the who.ini. i did give a login a test and got the "Sorry! You do not have permission to login to this system." which should mean everything is working for me :)

Comment 18

[Ed Morley [:emorley]]

Looking great - thank you :-)