823818 - Switch desktop nightly updates to using newer style snippets

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Here 'newer' means 'version=2' originally introduced in bug 459972. We need this so that we can use the attributes, and to keep nightly and release snippets in sync.

The code in question is at http://hg.mozilla.org/build/buildbotcustom/file/default/steps/updates.py#l58

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] tested patch

appVersion is the key parameter from the point of view of the client-side. This matches what we do for release, less detailsURL and actions.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 694694 [details] [diff] [review]
[buildbotcustom] tested patch

Tested fine. I generated two Linux 32bit nightlies in staging with this and was able to update using dev-stage01's AUS. Adding a promptWaitTime=120 to the snippet also worked (preliminary verification for bug 826446)

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 694694 [details] [diff] [review]
[buildbotcustom] tested patch

lgtm

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 694694 [details] [diff] [review]
[buildbotcustom] tested patch

http://hg.mozilla.org/build/buildbotcustom/rev/0d8b24626fe6

Comment 5

[[e-mail] (:bhearsum)]

In production.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Turns out we only switched en-US snippets so far.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Actually I was looking in the wrong place and desktop l10n is handled by the patch here. Did miss Fennec though, filed bug 830802 for that because it doesn't block all the deps here.