829222 - Please (temporarily?) specify promptWaitTime as 12 hours for Aurora snippets

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Alex Keybl [:akeybl]]

We'd like to do the same for Aurora, once 829221 has a day of bake time on Nightly.

+++ This bug was initially created as a clone of Bug #829221 +++

When possible, please temporarily specify promptWaitTime as 6 hours for Nightly snippets. QA will verify that the update notification prompt occurs 6 hours after the update ping instead of the default 12. Once that verification is completed, and we've had a day or so of bake time, we can move forward with the bug to do similar on Aurora.

Comment 1

[Alex Keybl [:akeybl]]

But the snippets will be set to have a backoff of 12 hours.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Note for RelEng: cron for aurora channel, ffxbld@aus3-staging

*/3  /home/ffxbld/bin/add-promptWaitTime.py -p /opt/aus2/incoming/2/Firefox/mozilla-aurora -w 43200

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Status: Waiting on dep bugs. See comment #2 for what to do.

Comment 4

[Alex Keybl [:akeybl]]

No longer blocked. We can enable this at the same time as Aurora updates on Friday, if possible.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Apologies for the delay, a 12 hour promptWaitTime is now enabled for aurora channel.

Comment 6

[u279076]

According to recent Aurora mozmill testruns promptWaitTime is 43200 for updates on aurora channel. If my math is correct this equates to 12 hours.

> https://aus3.mozilla.org/update/3/Firefox/25.0a2/20130813004004/WINNT_x86-msvc/en-US/aurora/Windows_NT%205.1/default/default/update.xml?force=1

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Reopening so we remember to remove this again.

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Found in triage. Should this be linked in with the migrations bugs, for easier tracking?

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

No, this is decoupled from migrations.

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Nick Thomas [:nthomas] from comment #7)
> Reopening so we remember to remove this again.

Why remove? Let's just leave as is and move forward with bug 829227. Thanks for doing this.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Is the summary out of date ? It talks about temporarily specifying 12 hours. If we are leaving Aurora on 12 hours then I might reconsider using the cron job we have now.

Comment 12

[Robert Strong (they/them - no direct email)]

Also, if we'd like the default for Aurora to be 12 hours then the Firefox pref should just be changed like bug 829229 changed it to 48 hours for release and beta and use the update.xml if we want it to be different for a specific update.

Comment 13

[Alex Keybl [:akeybl]]

(In reply to Nick Thomas [:nthomas] from comment #11)
> Is the summary out of date ? It talks about temporarily specifying 12 hours.
> If we are leaving Aurora on 12 hours then I might reconsider using the cron
> job we have now.

Honestly, I'm OK with a shorter prompt on Nightly/Aurora if users don't mind, since we want feedback quickly. No issue if we leave this as is and close it as fixed.

Rob's point would be clean in the longer-term, but I actually like exercising this code regularly.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Presumably we have test coverage for this code, so I'm not sure why we need to test it with users all the time. I don't want to leave the current solution in place, because it's just a hack for testing.

Comment 15

[Robert Strong (they/them - no direct email)]

Note: this is very well tested

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

I've removed cron job that was putting the 12 hour prompt wait time from the aurora snippets, rather than reimplement it in the new update server (we'll be using that post-merge next week). Lets handle any permanent shortening of the prompt time as a pref change.