824132 - Avoid resetting the theme on startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

When Gecko starts, if there is no theme, it sends a reset-theme message. This will cause all the registered views to set its own background again. This is unnecessary. We could use a state variable to monitor this -- just so to reset only if a theme is enabled.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This ensures reset is called only if it is ever set.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 695038 [details] [diff] [review]
Patch

This is OK, but could we use mBitmap as the "state"? If mBitmap is null, the theme is not enabled. If mBitmap is not null then the theme is enabled.

If we can use mBitmap, let's do it. If the boolean is better, I'm OK with it.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Pushed with mBitmap as the state:
    https://hg.mozilla.org/integration/mozilla-inbound/rev/30607c0b98c2

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/30607c0b98c2

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 695038 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Optimization.
User impact if declined: None.
Testing completed (on m-c, etc.): Landed in m-c on 12/27
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

(This patch is required for Bug 816114).

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f2e12c5b0ce6