Closed Bug 824132 Opened 8 years ago Closed 8 years ago

Avoid resetting the theme on startup

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20
Tracking Status
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(1 file)

When Gecko starts, if there is no theme, it sends a reset-theme message. This will cause all the registered views to set its own background again. This is unnecessary. We could use a state variable to monitor this -- just so to reset only if a theme is enabled.
Blocks: themes
Attached patch PatchSplinter Review
This ensures reset is called only if it is ever set.
Attachment #695038 - Flags: review?(mark.finkle)
Comment on attachment 695038 [details] [diff] [review]
Patch

This is OK, but could we use mBitmap as the "state"? If mBitmap is null, the theme is not enabled. If mBitmap is not null then the theme is enabled.

If we can use mBitmap, let's do it. If the boolean is better, I'm OK with it.
Attachment #695038 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/30607c0b98c2
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment on attachment 695038 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Optimization.
User impact if declined: None.
Testing completed (on m-c, etc.): Landed in m-c on 12/27
Risk to taking this patch (and alternatives if risky): Very low.
String or UUID changes made by this patch: None.

(This patch is required for Bug 816114).
Attachment #695038 - Flags: approval-mozilla-aurora?
Attachment #695038 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.