824162 - unable to focus into content in chat windows, iframe receives focus

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

- open 2 chat windows
- focus into one
- switch to a different application
- move the app so the non-focused chat window is visible
- click into the non-focused chat window
- start typing

If you do the last step fast enough, some of your message will appear in the chat window you clicked on, then focus gets moved back to the previously focused chat window, and your typing continues there.

Sometimes it will switch back and forth more than once.

I think this is a potential privacy issue: if you don't realize your focus changed, you may send a message to the wrong person.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

FWIW, I can't repro this with the demo provider on Windows.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: chatfocus.patch

This patch fixes some focus issues with the chat windows due to our advancing the focus during a focus event.  Using our demo provider, focus handling is now working as expected with both keyboard and mouse, additionally supporting focus into a chat window when firefox is not the current application.

This does not fix a facebook specific issue, which I now believe to be a bug on their end.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I don't really understand the logic behind the ownerDocument check. From what I understand, we should just avoid calling chatbox.focus() entirely from under the selectedChat setter, when it is invoked from the focus handler. That would probably require introducing a selectChat(chat, setFocus) helper or somesuch.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: chatfocus.patch

This is actually all that is necessary to fix the focus problem.

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b881843d330b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b881843d330b

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 698151 [details] [diff] [review]
chatfocus.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 8

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #7)
> Comment on attachment 698151 [details] [diff] [review]
> chatfocus.patch

Hmm, something here would probably be useful :)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: some focus problems when focusing onto chat windows,  a contributor to focus switching between chat windows unexpectedly.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk, affects only social chat windows
String or UUID changes made by this patch: none

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 698151 [details] [diff] [review]
chatfocus.patch

Only affects chat windows, so we'll take this uplift.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/13dc236d0fd8
https://hg.mozilla.org/releases/mozilla-beta/rev/fdf055c47686

Comment 11

[Virgil Dicu [:virgil] [QA]]

I tried to verify the fix for this issue on Firefox 19.0 beta 5 on Mac OS X 10.7.5
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130206083616

The focus is still switching from a chat window to another by following the steps from comment 0.

The same behavior on Latest Aurora and Latest Nightly on Mac 10.7.5.
I met this switch of chat window focus also on Windows 7 and Ubuntu 12.04 for Firefox 19.0 beta 5, Latest Aurora and Latest Nightly.

Comment 12

[Virgil Dicu [:virgil] [QA]]

Should we set this to REOPEN and move to ALL?

Comment 13

[Shane Caraveo (:mixedpuppy)]

(In reply to Virgil Dicu [:virgil] [QA] from comment #12)
> Should we set this to REOPEN and move to ALL?

As I said in comment 2, this patch does not address the facebook specific problem (where focus would switch back and forth between their chat windows).  I believe that is a bug on their side.

We did however, have a bug where, if firefox were not the top application, and you clicked into a chat window, we would focus the iframe rather than what you clicked on (e.g. textbox).  That is what this patch addresses.

Comment 14

[u279076]

(In reply to Shane Caraveo (:mixedpuppy) from comment #13)
> As I said in comment 2, this patch does not address the facebook specific
> problem (where focus would switch back and forth between their chat
> windows).  I believe that is a bug on their side.

Do we have a bug on file to track the issue on Facebook's end? We won't be able to verify this fixed 100% until it's 100% fixed.

Comment 15

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #14)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #13)
> > As I said in comment 2, this patch does not address the facebook specific
> > problem (where focus would switch back and forth between their chat
> > windows).  I believe that is a bug on their side.
> 
> Do we have a bug on file to track the issue on Facebook's end? We won't be
> able to verify this fixed 100% until it's 100% fixed.

Bug 839166 has been created for the issue on the provider side.

Comment 16

[u279076]

Okay, thanks Shane. Since we didn't find any regressions in our testing we won't block release on testing this further. We'll continue to track to test again once bug 839166 is fixed.

Comment 17

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old