824243 - Profiler is not localizable

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[u60234]

The new Profiler tool that landed in bug 795268 has its UI hard-coded in English. The only thing that is localizable is the tab in the developer tools window and the item in Firefox's Developer Tools menu.

Comment 2

[Anton Kovalyov (:anton)]

Attachment: Make Profiler UI localizable

Made all UI (incl. Cleopatra) strings localizable. Not that for Cleopatra I updated only those strings that are used in our Profiler.

Comment 3

[Anton Kovalyov (:anton)]

s/Not that/Note that/

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 707880 [details] [diff] [review]
Make Profiler UI localizable

Review of attachment 707880 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, although it totally breaks cleopatra out from the original repo. We're a total fork now.

I guess this means we can seriously consider making it themeable as bug 823026 suggests.

::: browser/devtools/profiler/profiler.xul
@@ +12,5 @@
>  
> +<!DOCTYPE window [
> +<!ENTITY % profilerDTD SYSTEM "chrome://browser/locale/devtools/profiler.dtd">
> +  %profilerDTD;
> +]>

ok!

::: browser/locales/en-US/chrome/browser/devtools/profiler.properties
@@ +52,5 @@
> +profiler.startProfiling=Click here %S to start profiling
> +
> +# LOCALIZATION NOTE (profiler.stopProfiling)
> +# This string is displayed around the button that stops the profiler.
> +profiler.stopProfiling = Click here %S to stop profiling

do these need string arguments? If so you should explain what they are.

Comment 5

[Anton Kovalyov (:anton)]

Attachment: Make Profiler UI localizable

Added additional comments explaining string arguments for startProfiling and stopProfiling strings.

Comment 6

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/44772e261a55

Comment 7

[Anton Kovalyov (:anton)]

Rob, my plan is to push strings.js (although modified) upstream. Then all we will need to modify is strings.js which makes it easier to pull changes from upstream.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/44772e261a55

Comment 9

[Francesco Lodolo [:flod]]

Can someone explain what "self" is expected to mean? I'm trying the profiler but I'm not sure about it.

I would also say that the strings displayed between the moment you stop the profiler and the graph is displayed are still hardcoded(processing working request..., finished and a couple others before these).

Comment 10

[Anton Kovalyov (:anton)]

"Self" is how much time was spent doing work directly in that function. As opposed to the total time which is how much time was spent in that function and in functions it called.

As for progress strings I was thinking about removing them at all (or replacing with "Loading...").

Comment 11

[Anton Kovalyov (:anton)]

Filed bug 837735 about removing strings.

Comment 12

[Francesco Lodolo [:flod]]

Thanks Anton, I think that adding this as a localization comment inside the file would be greatly appreciated by other localizers.

P.S. If you go for "loading...", don't forget to use the proper single unicode character ("loading…")