Profiler is not localizable

RESOLVED FIXED in Firefox 21

Status

defect
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: u60234, Assigned: anton)

Tracking

({l12y})

unspecified
Firefox 21
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

7 years ago
The new Profiler tool that landed in bug 795268 has its UI hard-coded in English. The only thing that is localizable is the tab in the developer tools window and the item in Firefox's Developer Tools menu.
Assignee

Updated

7 years ago
Duplicate of this bug: 831399
Assignee

Updated

7 years ago
Assignee: nobody → anton
Assignee

Comment 2

7 years ago
Posted patch Make Profiler UI localizable (obsolete) — Splinter Review
Made all UI (incl. Cleopatra) strings localizable. Not that for Cleopatra I updated only those strings that are used in our Profiler.
Attachment #707880 - Flags: review?(rcampbell)
Assignee

Comment 3

7 years ago
s/Not that/Note that/
Assignee

Updated

7 years ago
Status: NEW → ASSIGNED
Comment on attachment 707880 [details] [diff] [review]
Make Profiler UI localizable

Review of attachment 707880 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, although it totally breaks cleopatra out from the original repo. We're a total fork now.

I guess this means we can seriously consider making it themeable as bug 823026 suggests.

::: browser/devtools/profiler/profiler.xul
@@ +12,5 @@
>  
> +<!DOCTYPE window [
> +<!ENTITY % profilerDTD SYSTEM "chrome://browser/locale/devtools/profiler.dtd">
> +  %profilerDTD;
> +]>

ok!

::: browser/locales/en-US/chrome/browser/devtools/profiler.properties
@@ +52,5 @@
> +profiler.startProfiling=Click here %S to start profiling
> +
> +# LOCALIZATION NOTE (profiler.stopProfiling)
> +# This string is displayed around the button that stops the profiler.
> +profiler.stopProfiling = Click here %S to stop profiling

do these need string arguments? If so you should explain what they are.
Attachment #707880 - Flags: review?(rcampbell) → review+
Assignee

Comment 5

7 years ago
Added additional comments explaining string arguments for startProfiling and stopProfiling strings.
Attachment #707880 - Attachment is obsolete: true
Attachment #708703 - Flags: review+
Assignee

Updated

7 years ago
Whiteboard: [fixed-in-fx-team]
Assignee

Comment 7

7 years ago
Rob, my plan is to push strings.js (although modified) upstream. Then all we will need to modify is strings.js which makes it easier to pull changes from upstream.
https://hg.mozilla.org/mozilla-central/rev/44772e261a55
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Can someone explain what "self" is expected to mean? I'm trying the profiler but I'm not sure about it.

I would also say that the strings displayed between the moment you stop the profiler and the graph is displayed are still hardcoded(processing working request..., finished and a couple others before these).
Assignee

Comment 10

7 years ago
"Self" is how much time was spent doing work directly in that function. As opposed to the total time which is how much time was spent in that function and in functions it called.

As for progress strings I was thinking about removing them at all (or replacing with "Loading...").
Assignee

Comment 11

7 years ago
Filed bug 837735 about removing strings.
Thanks Anton, I think that adding this as a localization comment inside the file would be greatly appreciated by other localizers.

P.S. If you go for "loading...", don't forget to use the proper single unicode character ("loading…")

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.