Intermittent timeout in test_sts_privatebrowsing_perwindowpb.html | Test timed out.

RESOLVED FIXED in Firefox 20

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jdm, Assigned: andreshm)

Tracking

(Blocks: 1 bug, {intermittent-failure})

unspecified
Firefox 20
x86_64
Linux
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=18240445&tree=Firefox
Rev3 WINNT 6.1 mozilla-central opt test mochitest-other on 2012-12-24 06:09:44 PST for push dc2abccc2adb

slave: talos-r3-w7-085

The screenshot in the log shows that we're not suppressing the default window load (ie. the firstrun page).
(Reporter)

Updated

6 years ago
Blocks: 806731

Comment 1

6 years ago
(Keyword intermittent-failure is required in order for TBPL to suggest this for future failures)
Keywords: intermittent-failure
(Assignee)

Updated

6 years ago
Assignee: nobody → andres
(Assignee)

Comment 2

6 years ago
Created attachment 697706 [details] [diff] [review]
Patch v1
Attachment #697706 - Flags: review?(josh)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 4

6 years ago
Comment on attachment 697706 [details] [diff] [review]
Patch v1

Review of attachment 697706 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing_perwindowpb.html
@@ +28,5 @@
>      getInterface(Ci.nsIWebNavigation).QueryInterface(Ci.nsIDocShellTreeItem).
>      rootTreeItem.QueryInterface(Ci.nsIInterfaceRequestor).
>      getInterface(Ci.nsIDOMWindow);
>  
> +  mainWindow.Services.prefs.setIntPref("browser.startup.page", 0);

SpecialPowers.Services

@@ +57,5 @@
>    function testOnWindow(aIsPrivate, aCallback) {
>      var win = mainWindow.OpenBrowserWindow({private: aIsPrivate});
>      win.addEventListener("load", function onLoad() {
>        win.removeEventListener("load", onLoad, false);
> +      win.gBrowser.addEventListener("DOMContentLoaded", function onInnerLoad() {

Please check if the this event listener is actually required with the browser.startup.page pref set to 0.

@@ +218,5 @@
>      test_sts_after_exiting_private_mode
>    ];
>  
> +  function finish() {
> +    mainWindow.Services.prefs.clearUserPref("browser.startup.page")

Likewise.
Attachment #697706 - Flags: review?(josh)
(Assignee)

Comment 5

6 years ago
Created attachment 697920 [details] [diff] [review]
Patch v2

Applied suggested changes. The event listener is still required.
Attachment #697706 - Attachment is obsolete: true
Attachment #697920 - Flags: review?(josh)

Updated

6 years ago
Attachment #697920 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/220a958dd8e3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.