824493 - Intermittent timeout in test_sts_privatebrowsing_perwindowpb.html | Test timed out.

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Josh Matthews [:jdm]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=18240445&tree=Firefox
Rev3 WINNT 6.1 mozilla-central opt test mochitest-other on 2012-12-24 06:09:44 PST for push dc2abccc2adb

slave: talos-r3-w7-085

The screenshot in the log shows that we're not suppressing the default window load (ie. the firstrun page).

Comment 1

[Ed Morley [:emorley]]

(Keyword intermittent-failure is required in order for TBPL to suggest this for future failures)

Comment 2

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

Comment 3

[Andres Hernandez [:andreshm]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=29c79ba11d34

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 697706 [details] [diff] [review]
Patch v1

Review of attachment 697706 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/tests/mochitest/stricttransportsecurity/test_sts_privatebrowsing_perwindowpb.html
@@ +28,5 @@
>      getInterface(Ci.nsIWebNavigation).QueryInterface(Ci.nsIDocShellTreeItem).
>      rootTreeItem.QueryInterface(Ci.nsIInterfaceRequestor).
>      getInterface(Ci.nsIDOMWindow);
>  
> +  mainWindow.Services.prefs.setIntPref("browser.startup.page", 0);

SpecialPowers.Services

@@ +57,5 @@
>    function testOnWindow(aIsPrivate, aCallback) {
>      var win = mainWindow.OpenBrowserWindow({private: aIsPrivate});
>      win.addEventListener("load", function onLoad() {
>        win.removeEventListener("load", onLoad, false);
> +      win.gBrowser.addEventListener("DOMContentLoaded", function onInnerLoad() {

Please check if the this event listener is actually required with the browser.startup.page pref set to 0.

@@ +218,5 @@
>      test_sts_after_exiting_private_mode
>    ];
>  
> +  function finish() {
> +    mainWindow.Services.prefs.clearUserPref("browser.startup.page")

Likewise.

Comment 5

[Andres Hernandez [:andreshm]]

Attachment: Patch v2

Applied suggested changes. The event listener is still required.

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/220a958dd8e3

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/220a958dd8e3