824501 - Remove gradient from normal, private and synced tabs section headers

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121224 Firefox/20.0
Build ID: 20121224030902

Steps to reproduce:

The gradient doesn't fit the rest of the app which is sparse of highlighting gradients. I suggest a flat orange and also changing the top shadow to become a very subtle orange glow.

Comment 1

[Ian Barlow (:ibarlow)]

Don't worry, this isn't the final visual design. Functionality is being implemented first, visual polish is coming shortly.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: AllCaps text view

Android has this awesome attribute: android:textAllCaps. But only from 14!
Hence a small little custom view that can support all caps from version 8.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Tab highlight

This patch adds a orange highlight like holo theme tabs.
The pressed state differs from the Android -- to make it consistent with our other highlights.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1098469c5a5
https://hg.mozilla.org/integration/mozilla-inbound/rev/028161a1ebe5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1098469c5a5
https://hg.mozilla.org/mozilla-central/rev/028161a1ebe5

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700578 [details] [diff] [review]
Part 1: AllCaps text view

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature.
User impact if declined: Section headers won't have text in all CAPS.
Testing completed (on m-c, etc.): Landed in m-c on 01/12.
Risk to taking this patch (and alternatives if risky): Very low. Strings are changed to uppercase and shown.
String or UUID changes made by this patch: None.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 700590 [details] [diff] [review]
Part 2: Tab highlight

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature.
User impact if declined: Beautiful holo themed highlights will be missing.
Testing completed (on m-c, etc.): Landed in m-c on 01/12.
Risk to taking this patch (and alternatives if risky): Very low. This changes the color of the highlight on tabs.
String or UUID changes made by this patch: None.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 700578 [details] [diff] [review]
Part 1: AllCaps text view

Approving patches needed for Bug 817675 , considering all these are needed for private browsing feature landing in FF20 .

Comment 9

[Sriram Ramasubramanian [:sriram]]

Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/8f82e0ec113c
https://hg.mozilla.org/releases/mozilla-aurora/rev/db530424953a