824516 - Regression: cannot select the content text

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Enviroment:
http://hg.mozilla.org/mozilla-central/rev/84320dffec6e

Status:
I cannot select the page text.

Info:
This error is shown in logcat:
JavaScript Error: "ReferenceError: rootElement is not defined" (file: "chrome://browser/content/browser.js" line: 1546

In Bug 708048 (http://hg.mozilla.org/mozilla-central/rev/ce34fa2b2189),  NativeWindow._sendToContent was fixed. But this patch has the mistake that did not change |rootElement| to |target|.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch v1

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 695522 [details] [diff] [review]
patch v1

Review of attachment 695522 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Thank you for speedy review.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Does this patch fix bug 824516 as well?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

You mean bug 824475? Maybe, I'm not sure what's causing that one.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4b389a23a95

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4b389a23a95