824475 - Regression: Unable to invoke a context-menu on input fields and text-selection

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[ravicious]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121223 Firefox/20.0
Build ID: 20121223030832

Steps to reproduce:

Firefox for Android (Nightly, 20.0a1 2012-12-24)

I tried to paste my login and password from clipboard (I use KeePass) to login form on mobile Facebook page.


Actual results:

The option to paste the text didn't show up.


Expected results:

The option to paste the text should've show up.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Confirmed using G2 running Android 2.3.7 and today's nightly.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

This may be fixed by bug 824516

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

This has not been fixed yet after landing bug 824516.

Comment 5

[Aaron Train [:aaronmt]]

This is still broken on input fields and text-selection on Nightly (12/27). This is a loss of basic functionality in the browser.

Can we get a patch here?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

There's nothing obvious in the log when this happens. Can we get a regression window? Preferably on inbound.

Comment 7

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=73ce12dc950b&tochange=f578e6d37c13

Regression from bug 708048

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Patch

In this case we walk all the way up the tree to the HTMLElement looking for a title. HTMLElement doesn't have a hasAttribute method and throws.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 696072 [details] [diff] [review]
Patch

Review of attachment 696072 [details] [diff] [review]:
-----------------------------------------------------------------

You mean you walk all the way up to HTMLDocument? The parent node of the HTMLHtmlElement is the HTMLDocument.

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64aca6053504

Comment 11

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/64aca6053504

Comment 12

[Chris Peterson [:cpeterson]]

I would expect this fix to be in the Nightly builds already, but I can still repro this bug with Nightly build 2012-12-31.

Comment 13

[Wesley Johnston (:wesj)]

any particular page. the one in the url works for me as does bugzilla. maybe its hardware dependent or maybe you arent up to date?

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Wesley Johnston (:wesj) from comment #13)
> any particular page. the one in the url works for me as does bugzilla. maybe
> its hardware dependent or maybe you arent up to date?

Verified fixed in Nightly 20 (2013-01-02).