Closed
Bug 824612
Opened 12 years ago
Closed 12 years ago
B2G SMS: add marionette test script for strict 7bit encoding
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
Attachments
(1 file, 2 obsolete files)
8.54 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
The marionette test script was first uploaded in bug 816082 but removed temporarily later[1] due to bug 822207. Here we have some work-around, specifically limit the timeout in this script and increase MARIONETTE_TIMEOUT.
[1]: bug 816082 comment #33.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
still fails, maybe we have to rewrite the test case, save db transactions instead.
Assignee | ||
Comment 3•12 years ago
|
||
Concatenate test strings into one. This saves hundreds SMS db transactions and avoid bug 822207. Try: https://tbpl.mozilla.org/?tree=Try&rev=64003f2f846f.
Attachment #695619 -
Attachment is obsolete: true
Attachment #697322 -
Flags: review?(htsai)
Assignee | ||
Comment 4•12 years ago
|
||
Update the patch used in the try run.
Attachment #697322 -
Attachment is obsolete: true
Attachment #697322 -
Flags: review?(htsai)
Assignee | ||
Updated•12 years ago
|
Attachment #697749 -
Flags: review?(htsai)
Comment 5•12 years ago
|
||
Comment on attachment 697749 [details] [diff] [review]
marionette test case : v2
Review of attachment 697749 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #697749 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•